darcs

Patch 497 Fixed 'Use print' hlint suggestion every... (and 16 more)

Title Fixed 'Use print' hlint suggestion every... (and 16 more)
Superseder Nosy List dmitry.tsygankov
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-12-04.12:54:58 by dmitry.tsygankov, last changed 2011-05-10.21:05:37 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
fixed-_use-print_-hlint-suggestion-everywhere.dpatch dmitry.tsygankov, 2010-12-04.12:54:57 text/x-darcs-patch
unnamed dmitry.tsygankov, 2010-12-04.12:54:57
See mailing list archives for discussion on individual patches.
Messages
msg13288 (view) Author: dmitry.tsygankov Date: 2010-12-04.12:54:57
17 patches for repository http://darcs.net:

Cleaning things up little by little. 
Please let me know if you think this activity is to be avoided, 
'cause it looks like I can do this forever.   

Sat Nov 27 04:16:18 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Fixed 'Use print' hlint suggestion everywhere

Sat Nov 27 04:33:23 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * case -> fromMaybe

Sat Nov 27 13:21:52 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Remove unneeded parentheses

Sat Nov 27 13:26:06 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * case -> maybe in canonizeAfterSplitter

Sat Nov 27 13:27:08 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Remove a couple of dos and returns from deselectUnwanted

Mon Nov 29 22:31:03 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Cases -> maybes

Tue Nov 30 00:09:03 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Eliminate an extra occurence of selectChanges

Tue Nov 30 00:34:29 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Remove unneeded return ()

Tue Nov 30 01:18:46 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * >>= return to fmap

Tue Nov 30 02:16:53 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Take+length+(==) -> isPrefixOf

Tue Nov 30 02:26:47 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * case -> mplus in copyFileUsingCache

Fri Dec  3 01:43:12 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Removed an extra putAnn in annotateFile

Fri Dec  3 01:48:04 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * case -> fmap in getCheckInternal

Fri Dec  3 01:49:13 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Removed an extra liftIO in applyAndFix

Fri Dec  3 01:50:39 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * Removed an extra parameter from iw

Sat Dec  4 14:40:48 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * case -> fromMaybe in cleanCachesWithHint'

Sat Dec  4 15:15:26 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * isJust + fromJust -> maybe in rollItBackNow
Attachments
msg13289 (view) Author: ganesh Date: 2010-12-04.19:14:03
Hi Dmitry,

On Sat, 4 Dec 2010, Dmitry Tsygankov wrote:

> Cleaning things up little by little.
> Please let me know if you think this activity is to be avoided,
> 'cause it looks like I can do this forever.

I think cleaning things up is fine if you've got the patience for it. 
There are of course plenty of other things you could improve about darcs 
instead if you prefer :-)

> 17 patches for repository http://darcs.net:

One thing I should have mentioned earlier is that you should probably be 
making patches against the screened branch - http://darcs.net/screened - 
to minimise the incidence of conflicts. There's a bit more information 
about our current review workflow here: 
http://wiki.darcs.net/Development/PatchReview

Cheers,

Ganesh
msg13676 (view) Author: ganesh Date: 2011-02-12.11:56:34
I'm accepting the pieces of this that don't conflict with current 
unstable/screened.
msg13837 (view) Author: gh Date: 2011-04-01.10:47:17
Almost entirely accepted.
History
Date User Action Args
2010-12-04 12:54:58dmitry.tsygankovcreate
2010-12-04 19:14:03ganeshsetmessages: + msg13289
2010-12-16 17:08:13darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-e2b6bb91aa40767d72bc3e457975877dc4bfc63d
2011-02-12 11:56:34ganeshsetmessages: + msg13676
2011-04-01 10:47:17ghsetstatus: needs-review -> accepted
messages: + msg13837
2011-05-10 21:05:37darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-e2b6bb91aa40767d72bc3e457975877dc4bfc63d -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-e2b6bb91aa40767d72bc3e457975877dc4bfc63d