darcs

Patch 503 Don't require --darcs when it's not needed in darcs-te...

Title Don't require --darcs when it's not needed in darcs-te...
Superseder Nosy List galbolle
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-12-15.07:28:13 by galbolle, last changed 2011-05-10.20:36:10 by darcswatch.

Files
File name Status Uploaded Type Edit Remove
don_t-require-__darcs-when-it_s-not-needed-in-darcs_test-executable.dpatch galbolle, 2010-12-15.07:28:12 text/x-darcs-patch
unnamed galbolle, 2010-12-15.07:28:12
See mailing list archives for discussion on individual patches.
Messages
msg13327 (view) Author: galbolle Date: 2010-12-15.07:28:12
1 patch for repository http://darcs.net/screened:

Fri Dec 10 17:02:00 CET 2010  Florent Becker <florent.becker@ens-lyon.org>
  * Don't require --darcs when it's not needed in darcs-test executable
Attachments
msg13333 (view) Author: kowey Date: 2010-12-15.11:02:28
On Wed, Dec 15, 2010 at 07:28:13 +0000, Florent Becker wrote:
> Fri Dec 10 17:02:00 CET 2010  Florent Becker <florent.becker@ens-lyon.org>
>   * Don't require --darcs when it's not needed in darcs-test executable

Applied, thanks.

Don't require --darcs when it's not needed in darcs-test executable
-------------------------------------------------------------------
> - -    when (null (darcs conf)) $ fail ("No darcs specified. Perhaps --darcs `pwd`/dist/build/darcs/darcs?")
> - -    when (not (isAbsolute (darcs conf))) $ fail ("Argument to --darcs should be an absolute path")
> +    when (shell conf || network conf || failing conf) $ do
> +      when (null $ darcs conf) $
> +        fail ("No darcs specified. Perhaps --darcs `pwd`/dist/build/darcs/darcs?")
> +      when (not (isAbsolute (darcs conf))) $
> +        fail ("Argument to --darcs should be an absolute path")

Only require --darcs if we're actually calling darcs (ie. in some kind
of shell test)

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
For a faster response, try +44 (0)1273 64 2905 or
xmpp:kowey@jabber.fr (Jabber or Google Talk only)
msg13357 (view) Author: darcswatch Date: 2010-12-16.17:08:19
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-5562bb81fc39856bf17826e736ba5f396e098336
msg13361 (view) Author: darcswatch Date: 2010-12-16.17:08:20
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-5562bb81fc39856bf17826e736ba5f396e098336
msg14283 (view) Author: darcswatch Date: 2011-05-10.20:36:10
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-5562bb81fc39856bf17826e736ba5f396e098336
History
Date User Action Args
2010-12-15 07:28:13galbollecreate
2010-12-15 11:02:29koweysetmessages: + msg13333
2010-12-16 17:08:19darcswatchsetmessages: + msg13357
2010-12-16 17:08:20darcswatchsetstatus: needs-review -> accepted
messages: + msg13361
2011-05-10 20:36:10darcswatchsetmessages: + msg14283