Hi,

here is a bunch of patches to improve darcs send UI, with corresponding
tests.

Note that issue 2013 is not fully solved: darcs send --to x --context y
will not ask for a target email address, but if the --to tag is omitted,
darcs will NOT look for the default email address in the default
repository.

I think it is sane not to use the default address because the default
repo might not be related with the context file; nonetheless, it could
be nice to suggest/remind this address when asking for a target (Eric's
idea on IRC).  Note that this would imply querying the default repo,
although it is not related to the context file; no idea if this is an
issue.  Anyway, I think it is a _separate_ issue.

Best regards,
Gabriel

8 patches for repository http://darcs.net/screened:

Thu Dec  9 01:42:14 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
  * Remove redundant import

Thu Dec  9 12:01:26 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
  * resolve issue 2012: do not display target address with -o/-O

Thu Dec  9 14:52:04 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
  * Export Darcs.Externals.haveSendmail

Fri Dec 10 09:11:11 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
  * resolve issue2013: handle --to flags in darcs send --context

Fri Dec 10 10:46:10 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
  * resolve issue1344: abort early if can't send

Wed Dec 15 15:00:06 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
  * Test issue2013: do not ignore --to in darcs send --context

Wed Dec 15 15:00:19 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
  * Test issue1344: fail early if sendmail is not available

Wed Dec 15 15:46:19 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
  * Test issue2012: darcs send -o shall not print a "will be sent to" line

Attachments

• remove-redundant-import.dpatch
• unnamed

Hi,

The following patch (which entered screened):

  Mon Dec 13 19:51:11 CET 2010  Ganesh Sittampalam <ganesh@earth.li>
    * get rid of the ($-) operator

conflicts with this one (pending in the bug tracker, patch505):

  Fri Dec 10 09:11:11 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
    * resolve issue2013: handle --to flags in darcs send --context

The following patch resolves the conflict:

  Thu Jan 20 17:16:05 CET 2011  Gabriel Kerneis <kerneis@pps.jussieu.fr>
    * Fix conflict (because of $- removal)

If you wish to avoid conflicts, you can merge them in a single patch
before pushing it to screened.  Just warn me so that I remove them from
my own repository in that case.

Best,
-- 
Gabriel

Attachments

• resolve-issue2013_-handle-__to-flags-in-darcs-send-__context.dpatch
• unnamed
• unnamed

Patches look ok and tests are ok. It's in.

This patch bundle (with 9 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-3c8ffde609d05e1ae663a1f3827ab6eaba8e296f

This patch bundle (with 9 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-3c8ffde609d05e1ae663a1f3827ab6eaba8e296f