Patch 507 Do not try to replayRepository in optimi... (and 1 more)

Title Do not try to replayRepository in optimi... (and 1 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To

Created on 2010-12-16.11:42:28 by gh, last changed 2011-03-03.09:13:03 by gh.

File name Status Uploaded Type Edit Remove
do-not-try-to-replayrepository-in-optimize-__upgrade-_redundant_-broken__.dpatch gh, 2010-12-16.11:42:27 text/x-darcs-patch
unnamed gh, 2010-12-16.11:42:27
See mailing list archives for discussion on individual patches.
msg13346 (view) Author: gh Date: 2010-12-16.11:42:27
This comes from Petr's adventure branch "patch pile".
I agree doing replayRepository is redundant when doing optimize --upgrade,
I don't know why Petr calls it broken.

Anyway, when you optimize --upgrade
you don't care about checking whether the OF pristine is broken or not.
As for checking patch integrity of the initial repo, I don't *think* this
takes place at all, and the optimize --upgrade process will fail graciously anyway
if this happens. Hence the redundancy that is fixed by this patch.

2 patches for repository http://darcs.net/screened:

Thu Sep  2 18:20:24 CEST 2010  Petr Rockai <me@mornfall.net>
  * Do not try to replayRepository in optimize --upgrade (redundant, broken).

Thu Dec 16 12:23:24 CET 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * fix redundant import since not repairing when doing optimize --upgrade
msg13553 (view) Author: gh Date: 2011-01-21.13:04:25
Pushed it to screened (it is one of the patch bundles that got
"forgotten" by the patch tracker, so I'm setting it to "need-review"
msg13766 (view) Author: gh Date: 2011-03-03.09:13:03
Date User Action Args
2010-12-16 11:42:28ghcreate
2010-12-16 16:08:31ghsetstatus: needs-review -> needs-screening
2011-01-21 13:04:25ghsetstatus: needs-screening -> needs-review
messages: + msg13553
2011-03-03 09:13:03ghsetstatus: needs-review -> accepted
messages: + msg13766