This comes from Petr's adventure branch "patch pile".
I agree doing replayRepository is redundant when doing optimize --upgrade,
I don't know why Petr calls it broken.
Anyway, when you optimize --upgrade
you don't care about checking whether the OF pristine is broken or not.
As for checking patch integrity of the initial repo, I don't *think* this
takes place at all, and the optimize --upgrade process will fail graciously anyway
if this happens. Hence the redundancy that is fixed by this patch.
2 patches for repository http://darcs.net/screened:
Thu Sep 2 18:20:24 CEST 2010 Petr Rockai <email@example.com>
* Do not try to replayRepository in optimize --upgrade (redundant, broken).
Thu Dec 16 12:23:24 CET 2010 Guillaume Hoffmann <firstname.lastname@example.org>
* fix redundant import since not repairing when doing optimize --upgrade