Patch 508 Support easy testing of darcs executables not named 'd...

Title Support easy testing of darcs executables not named 'd...
Superseder Nosy List kowey
Related Issues
Status rejected Assigned To

Created on 2010-12-16.12:32:06 by kowey, last changed 2011-08-13.14:28:23 by anjemz.

File name Status Uploaded Type Edit Remove
enable-darcs_test-on-arbitrary-darcs.dpatch anjemz, 2011-08-13.14:28:23 application/octet-stream
support-easy-testing-of-darcs-executables-not-named-_darcs_.dpatch kowey, 2010-12-16.12:32:05 text/x-darcs-patch
unnamed kowey, 2010-12-16.12:32:05
See mailing list archives for discussion on individual patches.
msg13348 (view) Author: kowey Date: 2010-12-16.12:32:05
1 patch for repository http://darcs.net/screened:

This could use some a tiny bit of scrutiny from somebody who
knows their way through bash pretty well.  What I'm worried
about is things like aliases leaking in, or versions of darcs
not being consistent (for example, without the eval change,
not darcs and darcs would use different versions).

Don't tell me we have to unit test our test harness.

Thu Dec 16 11:57:14 GMT 2010  Eric Kow <kowey@darcs.net>
  * Support easy testing of darcs executables not named 'darcs'
  For tests that use the lib, this fixes a bug where passing in
  /foo/bin/darcs-2.4.4 causes the test to run on /foo/bin/darcs

This email has been scanned by MessageLabs' Email Security
System on behalf of the University of Brighton.
For more information see http://www.brighton.ac.uk/is/spam/
msg13871 (view) Author: ganesh Date: 2011-04-02.12:27:21
breaks on Windows:

(1) the DARCS environment variable has windows slashes in it, which end 
up being treated as escape characters during the alias expansion. We can 
fix that by doubling them in the setenv "DARCS" dp call

(2) eval "$@" instead of "$@" is needed to ensure alias expansion, but 
isn't quite the same in terms of escaping inside arguments. Not entirely 
sure how this could be fixed.

My overall feeling (discussed with Eric) is that this is too 
fragile/error-prone, and the best way to achieve this goal would be to 
setup a temporary directory on the PATH and copy the requested darcs-foo 
binary to that directory with the name darcs. That'll keep our tests 
nice-looking (darcs xxx rather than $DARCS xxx) and also be fairly 
I think there's
Date User Action Args
2010-12-16 12:32:06koweycreate
2011-04-02 12:27:22ganeshsetstatus: needs-review -> rejected
messages: + msg13871
2011-08-13 14:28:23anjemzsetfiles: + enable-darcs_test-on-arbitrary-darcs.dpatch