Patch 525: get rid of the ($-) operator (and 3 more) - Darcs bug tracker

Title	get rid of the ($-) operator (and 3 more)
Superseder		Nosy List	ganesh
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2011-01-04.23:20:28 by ganesh, last changed 2011-05-10.19:06:36 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
get-rid-of-the-____-operator.dpatch		ganesh, 2011-01-04.23:20:26	text/x-darcs-patch
get-rid-of-the-____-operator.dpatch		ganesh, 2011-01-19.23:20:11	text/x-darcs-patch
unnamed		ganesh, 2011-01-04.23:20:26
unnamed		ganesh, 2011-01-19.23:20:11

See mailing list archives for discussion on individual patches.

Messages
msg13447 (view)	Author: ganesh	Date: 2011-01-04.23:20:26
Hi, I'm not going to self-screen this immediately (apart from the issue1988 cleanup), because I'd like some feedback on whether the change is a good thing. The basic idea is to make it easier to have repository operations that aren't polymorphic on every kind of patch type. This need comes up in the existing code, where for example convert currently hacks around it with unsafeCoerce; and it's also something I want for rebase. So instead of the $- operator, callers of withRepoLock etc pass in a "job". The old kind of polymorphic job is a "RepoJob", but I then go on to add V1Job and V2Job to deal with what convert needs. Cheers, Ganesh 4 patches for repository http://darcs.net/screened: Mon Dec 13 18:51:11 GMT 2010 Ganesh Sittampalam <ganesh@earth.li> * get rid of the ($-) operator Wrap up the Rank2 types of the repository handling operations in a datatype rather than requiring the specialised ($-). This helps with a planned change to add more functionality to these operations. Mon Dec 13 19:02:59 GMT 2010 Ganesh Sittampalam <ganesh@earth.li> * generic job transformation function Mon Dec 13 19:13:54 GMT 2010 Ganesh Sittampalam <ganesh@earth.li> * issue1988 cleanup: accept warning Tue Dec 21 19:22:15 GMT 2010 Ganesh Sittampalam <ganesh@earth.li> * add new types of repository job to clean up Convert a bit Still not pretty, but at least the unsafeCoerce# is further down! Attachments get-rid-of-the-____-operator.dpatch unnamed
msg13492 (view)	Author: mornfall	Date: 2011-01-09.11:08:36
I have reviewed the patch, and the only minor quibble was the use of error (where I would prefer fail myself). Not a blocker, either way.
msg13529 (view)	Author: ganesh	Date: 2011-01-19.23:20:11
updated version with error -> fail. I'm pushing these to screened now. 3 patches for repository http://darcs.net/screened: Mon Dec 13 18:51:11 GMT 2010 Ganesh Sittampalam <ganesh@earth.li> * get rid of the ($-) operator Wrap up the Rank2 types of the repository handling operations in a datatype rather than requiring the specialised ($-). This helps with a planned change to add more functionality to these operations. Mon Dec 13 19:02:59 GMT 2010 Ganesh Sittampalam <ganesh@earth.li> * generic job transformation function Mon Jan 10 07:00:17 GMT 2011 Ganesh Sittampalam <ganesh@earth.li> * add new types of repository job to clean up Convert a bit Still not pretty, but at least the unsafeCoerce# is further down! Attachments get-rid-of-the-____-operator.dpatch unnamed
msg13636 (view)	Author: gh	Date: 2011-02-05.19:03:03
Reviewed by mornfall.
msg13638 (view)	Author: darcswatch	Date: 2011-02-05.19:16:12
This patch bundle (with 3 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-04b25b1bc9f425111e384a9c609c5d14dc319e3e
msg14077 (view)	Author: darcswatch	Date: 2011-05-10.17:36:54
This patch bundle (with 3 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-04b25b1bc9f425111e384a9c609c5d14dc319e3e

History
Date	User	Action	Args
2011-01-04 23:20:28	ganesh	create
2011-01-04 23:21:01	ganesh	set	status: needs-review -> needs-screening
2011-01-04 23:22:05	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0df80dd36490c4a70db57fbe9ecf4cb02562961e
2011-01-09 11:08:37	mornfall	set	status: needs-screening -> accepted-pending-tests messages: + msg13492
2011-01-19 23:20:11	ganesh	set	files: + get-rid-of-the-____-operator.dpatch, unnamed messages: + msg13529
2011-01-22 15:17:45	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0df80dd36490c4a70db57fbe9ecf4cb02562961e -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-04b25b1bc9f425111e384a9c609c5d14dc319e3e
2011-02-05 19:03:03	gh	set	status: accepted-pending-tests -> accepted messages: + msg13636
2011-02-05 19:16:12	darcswatch	set	messages: + msg13638
2011-05-10 17:36:54	darcswatch	set	messages: + msg14077
2011-05-10 19:06:36	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-04b25b1bc9f425111e384a9c609c5d14dc319e3e -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-0df80dd36490c4a70db57fbe9ecf4cb02562961e