darcs

Patch 543 Test for issue2041 (and 1 more)

Title Test for issue2041 (and 1 more)
Superseder Nosy List exlevan
Related Issues
Status accepted Assigned To
Milestone

Created on 2011-02-09.23:16:01 by exlevan, last changed 2011-02-22.15:43:53 by gh.

Files
File name Status Uploaded Type Edit Remove
test-for-issue2041.dpatch exlevan, 2011-02-09.23:16:01 application/x-darcs-patch
unnamed exlevan, 2011-02-09.23:16:01 text/x-darcs-patch
unnamed exlevan, 2011-02-09.23:16:01
See mailing list archives for discussion on individual patches.
Messages
msg13660 (view) Author: exlevan Date: 2011-02-09.23:16:01
The code that followed symlinks belongs to Darcs.RepoPath.ioAbsolute, so
this change will affect all commands that accept file arguments.  This
shouldn't cause any troubles, since the tests for issue1645 do a lot of
work ensuring that symlinks are handled correctly.  The
Darcs.Commands.Add module didn't require any changes, there aready was
code for rejecting symlinked directories (it just wasn't getting any).

2 patches for repository http://darcs.net/screened:

Thu Feb 10 00:17:20 EET 2011  Alexey Levan
  * Test for issue2041

Thu Feb 10 00:19:47 EET 2011  Alexey Levan
  * Resolve issue2041: prevent Darcs from following the directory symlinks
Attachments
msg13734 (view) Author: gh Date: 2011-02-22.15:43:53
Discussed on IRC: http://irclog.perlgeek.de/darcs/2011-02-22#i_3322729

I'm also pushing a followup haddock.
History
Date User Action Args
2011-02-09 23:16:01exlevancreate
2011-02-10 22:04:53exlevansetstatus: needs-review -> needs-screening
2011-02-12 00:42:28ganeshsetstatus: needs-screening -> needs-review
2011-02-22 15:43:53ghsetstatus: needs-review -> accepted
messages: + msg13734