darcs

Patch 591 no longer use init's advanced options fo... (and 1 more)

Title no longer use init's advanced options fo... (and 1 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2011-04-12.19:41:10 by gh, last changed 2011-07-26.20:23:23 by ganesh.

Files
File name Status Uploaded Type Edit Remove
no-longer-use-init_s-advanced-options-for-get.dpatch gh, 2011-04-12.19:41:09 application/x-darcs-patch
unnamed gh, 2011-04-12.19:41:09 text/x-darcs-patch
unnamed gh, 2011-04-12.19:41:09
See mailing list archives for discussion on individual patches.
Messages
msg13923 (view) Author: gh Date: 2011-04-12.19:41:09
Two cleanup patches.

2 patches for repository http://darcs.net/screened:

Sun Apr 10 13:35:44 CEST 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * no longer use init's advanced options for get

Sun Apr 10 19:37:11 CEST 2011  Guillaume Hoffmann <guillaumh@gmail.com>
  * remove two exported unused functions from Darcs.Externals
Attachments
msg14462 (view) Author: galbolle Date: 2011-05-26.11:26:45
Applying

no longer use init's advanced options for get
---------------------------------------------
Guillaume Hoffmann <guillaumh@gmail.com>**20110410113544

Ok
hunk ./src/Darcs/Commands/Get.hs 50
>  import Darcs.Patch.Depends ( findCommonWithThem, countUsThem )
>  import Darcs.Repository.Prefs ( setDefaultrepo )
>  import Darcs.Repository.Motd ( showMotd )
> -import Darcs.Commands.Init ( initialize )
>  import Darcs.Match ( havePatchsetMatch, getOnePatchset )
>  import Progress ( debugMessage )
>  import Printer ( text, errorDoc, ($$) )

hunk ./src/Darcs/Commands/Get.hs 102
>                      commandPrereq = contextExists,
>                      commandGetArgPossibilities = return [],
>                      commandArgdefaults = nodefaults,
> -                    commandAdvancedOptions = networkOptions ++ usePacks :
> -                                               commandAdvancedOptions
initialize,
> +                    commandAdvancedOptions = usePacks:networkOptions,
>                      commandBasicOptions = [reponame,
>                                              partial,
>                                              matchOneContext,

commandAdvancedOptions initialize was empty anyway.


remove two exported unused functions from Darcs.Externals
---------------------------------------------------------
Guillaume Hoffmann <guillaumh@gmail.com>**20110410173711

Ok
History
Date User Action Args
2011-04-12 19:41:10ghcreate
2011-04-28 09:26:44galbollesetstatus: needs-screening -> needs-review
2011-05-26 11:26:46galbollesetmessages: + msg14462
2011-05-26 11:26:51galbollesetstatus: needs-review -> accepted-pending-tests
2011-07-26 20:23:23ganeshsetstatus: accepted-pending-tests -> accepted