This depends on hashed-storage 0.5.7, which contains the real code for checking pristine. 
We have to wait until that is released to apply this patch.
Note also that check now considers 2.4 pristines to be broken.

1 patch for repository http://darcs.net:

Wed May 11 09:16:21 CEST 2011  Florent Becker <florent.becker@ens-lyon.org>
  * resolve issue2001: Fix repair and check in the case where pristine is corrupted

Attachments

• resolve-issue2001_-fix-repair-and-check-in-the-case-where-pristine-is-corrupted.dpatch
• unnamed

h-s 0.5.7 is available now so I tried this.

This seems to break the test 'pristine-problems.sh' - could you check?

I'm running on Windows, haven't tried on Linux.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 02/06/2011 20:10, Ganesh Sittampalam a écrit :
> 
> h-s 0.5.7 is available now so I tried this.
> 
> This seems to break the test 'pristine-problems.sh' - could you check?
> 
> I'm running on Windows, haven't tried on Linux.
> 
It seems to be working ok on Linux. Sadly, I don't have access to a
windows machine (or a mac, for that matter). I haven't sent Petr tests
for the function I added to hashed-storage, but it's probably what's
causing trouble. Can you get any useful output from the windows test?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3ooN8ACgkQTCPcDztjGo7sAgCeK9XUW/xoOVS3ZXsKAM2aZe8a
+PoAoJrOV8Qm2WQh3xB79/Na03NdShnn
=vLCr
-----END PGP SIGNATURE-----

On 03/06/2011 10:03, Florent Becker wrote:

> It seems to be working ok on Linux. Sadly, I don't have access to a
> windows machine (or a mac, for that matter). I haven't sent Petr tests
> for the function I added to hashed-storage, but it's probably what's
> causing trouble. Can you get any useful output from the windows test?

Here's the output from the test, but I'm not sure if it's actually
useful. Otherwise, I'll do some more debugging tonight.

Ganesh

Attachments

• pristine-problems.log

That output is strange: it's what I had when I didn't catch all
exceptions in Storage.Hashed.Tree.checkExpand . Can you try running the
test with darcs check --debug for the last call?

Here we are with --debug.

Attachments

• pristine-problems.log

Implementation of check and repair has changed a couple of times since
this patch, marking it as obsoleted.