darcs

Patch 608 resolve issue2001: Fix repair and check in the case wh...

Title resolve issue2001: Fix repair and check in the case wh...
Superseder Nosy List galbolle
Related Issues
Status followup-requested Assigned To galbolle
Milestone 2.12.0

Created on 2011-05-11.07:56:27 by galbolle, last changed 2016-04-01.20:10:04 by gh. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
pristine-problems.log ganesh, 2011-06-03.12:56:42 text/plain
pristine-problems.log ganesh, 2011-06-03.22:31:28 application/octet-stream
resolve-issue2001_-fix-repair-and-check-in-the-case-where-pristine-is-corrupted.dpatch galbolle, 2011-05-11.07:56:27 text/x-darcs-patch
unnamed galbolle, 2011-05-11.07:56:27
See mailing list archives for discussion on individual patches.
Messages
msg14442 (view) Author: galbolle Date: 2011-05-11.07:56:27
This depends on hashed-storage 0.5.7, which contains the real code for checking pristine. 
We have to wait until that is released to apply this patch.
Note also that check now considers 2.4 pristines to be broken.

1 patch for repository http://darcs.net:

Wed May 11 09:16:21 CEST 2011  Florent Becker <florent.becker@ens-lyon.org>
  * resolve issue2001: Fix repair and check in the case where pristine is corrupted
Attachments
msg14479 (view) Author: ganesh Date: 2011-06-02.18:10:11
h-s 0.5.7 is available now so I tried this.

This seems to break the test 'pristine-problems.sh' - could you check?

I'm running on Windows, haven't tried on Linux.
msg14489 (view) Author: galbolle Date: 2011-06-03.09:03:17
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le 02/06/2011 20:10, Ganesh Sittampalam a écrit :
> 
> h-s 0.5.7 is available now so I tried this.
> 
> This seems to break the test 'pristine-problems.sh' - could you check?
> 
> I'm running on Windows, haven't tried on Linux.
> 
It seems to be working ok on Linux. Sadly, I don't have access to a
windows machine (or a mac, for that matter). I haven't sent Petr tests
for the function I added to hashed-storage, but it's probably what's
causing trouble. Can you get any useful output from the windows test?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3ooN8ACgkQTCPcDztjGo7sAgCeK9XUW/xoOVS3ZXsKAM2aZe8a
+PoAoJrOV8Qm2WQh3xB79/Na03NdShnn
=vLCr
-----END PGP SIGNATURE-----
msg14490 (view) Author: ganesh Date: 2011-06-03.12:56:42
On 03/06/2011 10:03, Florent Becker wrote:

> It seems to be working ok on Linux. Sadly, I don't have access to a
> windows machine (or a mac, for that matter). I haven't sent Petr tests
> for the function I added to hashed-storage, but it's probably what's
> causing trouble. Can you get any useful output from the windows test?

Here's the output from the test, but I'm not sure if it's actually
useful. Otherwise, I'll do some more debugging tonight.

Ganesh
Attachments
msg14492 (view) Author: galbolle Date: 2011-06-03.17:19:06
That output is strange: it's what I had when I didn't catch all
exceptions in Storage.Hashed.Tree.checkExpand . Can you try running the
test with darcs check --debug for the last call?
msg14494 (view) Author: ganesh Date: 2011-06-03.22:31:28
Here we are with --debug.
Attachments
History
Date User Action Args
2011-05-11 07:56:27galbollecreate
2011-05-11 07:57:45darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-46cd7851f10a1bca64c9c3ac74e36afc2223b102
2011-06-02 18:10:11ganeshsetstatus: needs-screening -> followup-requested
assignedto: galbolle
messages: + msg14479
2011-06-03 09:03:17galbollesetmessages: + msg14489
2011-06-03 12:56:42ganeshsetfiles: + pristine-problems.log
messages: + msg14490
title: resolve issue2001: Fix repair and check in the case wh... -> resolve issue2001: Fix repair and check in the case wh...
2011-06-03 17:19:06galbollesetmessages: + msg14492
2011-06-03 22:31:28ganeshsetfiles: + pristine-problems.log
messages: + msg14494
2016-04-01 20:10:04ghsetmilestone: 2.12.0