2 patches for repository http://darcs.net/screened:

Thu May 19 22:57:59 BST 2011  Owen Stephens <darcs@owenstephens.co.uk>
  * Make no changes if any to-be-added file errors.
  Prior to this patch, the first file to be added to a new directory would
  implicitly add the directory. If the file itself didn't exist, the
  directory-add would still be present. Now, if any file-add fails, no changes
  are made.

Thu May 19 22:59:31 BST 2011  Owen Stephens <darcs@owenstephens.co.uk>
  * Fix test using incorrect grep pattern for failed add.

Attachments

• make-no-changes-if-any-to_be_added-file-errors_.dpatch
• unnamed
• unnamed

I'm going to screen this, but as a preliminary review comment, I think 
this might be a bit extreme; often you want to add a whole directory of 
stuff and tolerate some failures. Might be worth a discussion on darcs-
users for use cases here (which should then be codified as tests).

Owen, do you think you could start the aforementioned discussion about how 
darcs add ought to behave?

This looks fine, accepting pending tests.

It seems Darcs exits with failure if it detects that no adds were made.

On Sat, May 21, 2011 at 21:46:35 +0000, Ganesh Sittampalam wrote:
> I'm going to screen this, but as a preliminary review comment, I think 
> this might be a bit extreme; often you want to add a whole directory of 
> stuff and tolerate some failures. Might be worth a discussion on darcs-
> users for use cases here (which should then be codified as tests).

I've gone ahead and filed this as issue2100 and submitted patch674
as a test.

Prior to patch590, darcs was "relying" on an uncaught exception to
terminate darcs add when the first file does not exist.  Unfortunately,
I must have not run the full test suite and ended up costing the team
time and a logjam :-(

Basically, I think the situation looks like this:

darcs init
mkdir d
darcs add d/non-existent
# A: don't leave 'adddir d' lying around
# B: clean error message
touch d/f
darcs add d/non-existent d/f
# C: *do* add d and d/f

before   : A C
patch590 :  BC 
patch609 : AB
issue2100: ABC

-- 
Eric Kow <http://erickow.com>