darcs

Patch 705 Resolve issue2116: darcs dist --index no longer fails

Title Resolve issue2116: darcs dist --index no longer fails
Superseder Nosy List mndrix, stulli
Related Issues
Status accepted Assigned To stulli
Milestone

Created on 2012-01-24.21:00:20 by stulli, last changed 2012-03-15.15:44:35 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
resolve-issue2116_-darcs-dist-__index-no-longer-fails.dpatch stulli, 2012-01-24.21:00:20 text/x-darcs-patch
unnamed stulli, 2012-01-24.21:00:20
See mailing list archives for discussion on individual patches.
Messages
msg15057 (view) Author: stulli Date: 2012-01-24.21:00:20
This patch isn't ideal since dist --index behaves different than for
example changes --index or annotate --index; in changes and annotate
--index 1 gives you the latest patch and --index 0 is either unspecified
or the same as --index 1 whereas dist --index 0 (with this patch) 
creates a tarball with all patches and --index 1 with all patches minus
the latest.
dist --index <maxPatchCount> creates a tarball containing an empty
directory.
dist --index x-y works like --index 0 (same with annotate --index x-y) 
and should probably produce an error.

I have a neat table with the --index behaviour for several commands 
including exit codes if somebody is interested.

1 patch for repository http://darcs.net/screened:

Tue Jan 24 21:03:13 CET 2012  andreas.brandt.de@googlemail.com
  * Resolve issue2116: darcs dist --index no longer fails
Attachments
msg15067 (view) Author: darcswatch Date: 2012-01-28.14:24:36
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-c38461503b67e6a7aadb2244f9789d77d36605a5
msg15309 (view) Author: mndrix Date: 2012-03-13.23:24:05
It might be worth moving the "darcs dist --index 1" test in tests/failing-
index-argument.sh out of the "failing tests" section.  This patch makes 
that part of the test succeed.

As mentioned in msg15057, dist --index behaves differently than other --
index options.  I think it's worth describing the behavior in dist --help 
so that users are aware of the differences.

I think the documentation is reason enough to hold off on accepting the 
patch just yet.  Committers, please correct me if I'm wrong or chose the 
wrong patch status.
msg15330 (view) Author: darcswatch Date: 2012-03-15.15:44:35
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-c38461503b67e6a7aadb2244f9789d77d36605a5
History
Date User Action Args
2012-01-24 21:00:20stullicreate
2012-01-24 21:01:23darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-c38461503b67e6a7aadb2244f9789d77d36605a5
2012-01-28 14:24:37darcswatchsetstatus: needs-screening -> needs-review
messages: + msg15067
2012-03-13 23:24:06mndrixsetstatus: needs-review -> followup-requested
nosy: + mndrix
messages: + msg15309
assignedto: stulli
2012-03-15 15:44:35darcswatchsetstatus: followup-requested -> accepted
messages: + msg15330