darcs

Patch 706 Add Haddock header to Darcs.Annotate (and 1 more)

Title Add Haddock header to Darcs.Annotate (and 1 more)
Superseder Nosy List mndrix, wlangstroth
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-01-28.13:32:20 by wlangstroth, last changed 2012-03-24.16:30:25 by gh.

Files
File name Status Uploaded Type Edit Remove
add-haddock-header-to-darcs_annotate.dpatch wlangstroth, 2012-01-28.13:32:19 application/x-darcs-patch
patch-preview.txt wlangstroth, 2012-01-28.13:32:19 text/x-darcs-patch
unnamed wlangstroth, 2012-01-28.13:32:19
See mailing list archives for discussion on individual patches.
Messages
msg15064 (view) Author: wlangstroth Date: 2012-01-28.13:32:19
Applies some whitespace and formatting, following the proposed style guide.

2 patches for repository http://darcs.net:

Wed Jan 25 22:08:55 EST 2012  Will Langstroth <will@langstroth.com>
  * Add Haddock header to Darcs.Annotate

Sat Jan 28 08:26:15 EST 2012  Will Langstroth <will@langstroth.com>
  * Readability changes to Darcs.Annotate
Attachments
msg15301 (view) Author: mndrix Date: 2012-03-13.03:16:34
> -updateFile :: ([B.ByteString] -> AnnotatedM [B.ByteString]) -> 
AnnotatedM ()
> +updateFile :: ([B.ByteString]
> +           -> AnnotatedM [B.ByteString])
> +           -> AnnotatedM ()

I probably would have left the first argument's type signature on one 
line.  Until I spotted the parentheses, I assumed updateFile took two 
arguments rather than a single function argument.

The rest of the patches look good and the above is only minor, so can a 
committer please push this patch.
History
Date User Action Args
2012-01-28 13:32:20wlangstrothcreate
2012-02-22 21:14:36ganeshsetstatus: needs-screening -> needs-review
2012-03-13 03:16:34mndrixsetstatus: needs-review -> accepted-pending-tests
nosy: + mndrix
messages: + msg15301
2012-03-24 16:30:25ghsetstatus: accepted-pending-tests -> accepted