darcs

Patch 762 style and cleanup Darcs.Commands.Get and... (and 1 more)

Title style and cleanup Darcs.Commands.Get and... (and 1 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-03-26.23:55:13 by gh, last changed 2012-03-30.17:59:13 by kowey.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt gh, 2012-03-26.23:55:12 text/x-darcs-patch
style-and-cleanup-darcs_commands_get-and-darcs_repository.dpatch gh, 2012-03-26.23:55:12 application/x-darcs-patch
unnamed gh, 2012-03-26.23:55:12
See mailing list archives for discussion on individual patches.
Messages
msg15402 (view) Author: gh Date: 2012-03-26.23:55:12
The Darch.Repository.Internal patch belows removes the code of repository
IO (RIO) written in september 2008 by Jason Dagit. This code was
never used and hence may be out of sync with the rest of the code of darcs.
( For a history of RIO, you can consult
 http://lists.osuosl.org/pipermail/darcs-users/2008-September/,

and for an explanation of why the code isn't actually used; see:

http://lists.osuosl.org/pipermail/darcs-users/2008-September/013638.html
)

I'm not proposing to remove this code on the basis that a repository
IO monad is a bad idea or that this particular implementation is bad.
Just that old and never-used code can induce confusion, or worse, attempts
to use it against a too-different codebase.

2 patches for repository http://darcs.net:
 
Mon Mar 26 20:04:50 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * style and cleanup Darcs.Commands.Get and Darcs.Repository

Mon Mar 26 20:43:42 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * style and cleanup Darcs.Repository.Internal
Attachments
msg15429 (view) Author: kowey Date: 2012-03-30.17:53:00
At least screening the style patch.  Not sure breaking up the module 
imports that aggressively is that helpful.  Will wait for somebody else 
to do the whitespace stuff.
msg15430 (view) Author: kowey Date: 2012-03-30.17:59:11
Oh, sorry, for some reason didn't realise the second patch was an easy 
one

Yeah, old code we're not using is a liability.  I wonder: do we need to 
be working harder at recording this high-level history somewhere?  But 
where?

(btw, core team people should consider screening their own patches by 
default)
History
Date User Action Args
2012-03-26 23:55:13ghcreate
2012-03-30 17:46:04koweysetstatus: needs-screening -> review-in-progress
2012-03-30 17:53:01koweysetmessages: + msg15429
2012-03-30 17:59:13koweysetstatus: review-in-progress -> accepted
messages: + msg15430