darcs

Patch 776 Layout/tidy of Repository/HashedRepo (and 7 more)

Title Layout/tidy of Repository/HashedRepo (and 7 more)
Superseder Layout/tidy of Repository/HashedRepo (and 7 more)
View: 785
Nosy List owst
Related Issues
Status obsoleted Assigned To owst
Milestone

Created on 2012-03-31.17:26:45 by owst, last changed 2012-04-01.14:39:02 by kowey.

Files
File name Status Uploaded Type Edit Remove
layout_tidy-of-repository_hashedrepo.dpatch owst, 2012-03-31.17:26:45 application/x-darcs-patch
layout_tidy-of-repository_hashedrepo.dpatch kowey, 2012-04-01.10:33:14 application/x-darcs-patch
patch-preview.txt owst, 2012-03-31.17:26:45 text/x-darcs-patch
patch-preview.txt kowey, 2012-04-01.10:33:14 text/x-darcs-patch
unnamed owst, 2012-03-31.17:26:45
unnamed kowey, 2012-04-01.10:33:14
See mailing list archives for discussion on individual patches.
Messages
msg15457 (view) Author: owst Date: 2012-03-31.17:26:45
Refactor/clean/haddock HashedRepo...

8 patches for repository http://darcs.net:

Sat Mar 31 12:33:33 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Layout/tidy of Repository/HashedRepo

Sat Mar 31 12:41:40 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Change fmap -> <$> in HashedRepo

Sat Mar 31 12:53:20 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * hlint suggestions to HashedRepo

Sat Mar 31 14:10:51 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Extract string literals for top-level identifiers for inventories/pristine paths in HashedRepo

Sat Mar 31 15:18:56 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Extract out the use of "pristine: " literal into an identifier

Sat Mar 31 18:11:17 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Refactor listInventories function in HashedRepo

Sat Mar 31 18:21:01 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Extract duplicated code in readInventoryPrivate, in HashedRepo

Sat Mar 31 18:22:45 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Haddock HashedRepo, and make a few fairly trivial refactorings
Attachments
msg15458 (view) Author: kowey Date: 2012-03-31.17:44:57
I asked owst if he'd rebase on top of the witness stuff, as he's 
reviewing that

(thanks, Owen!)
msg15470 (view) Author: kowey Date: 2012-04-01.10:33:14
8 patches for repository http://darcs.net:

Sun Apr  1 11:21:26 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Layout/tidy of Repository/HashedRepo

Sun Apr  1 11:21:39 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Change fmap -> <$> in HashedRepo

Sun Apr  1 11:22:21 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * hlint suggestions to HashedRepo

Sun Apr  1 11:24:07 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Extract string literals for top-level identifiers for inventories/pristine paths in HashedRepo

Sun Apr  1 11:25:14 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Extract duplicated code in readInventoryPrivate, in HashedRepo

Sun Apr  1 11:25:21 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Refactor listInventories function in HashedRepo

Sun Apr  1 11:25:26 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Extract out the use of "pristine: " literal into an identifier

Sun Apr  1 11:25:29 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Haddock HashedRepo, and make a few fairly trivial refactorings
Attachments
msg15471 (view) Author: owst Date: 2012-04-01.10:37:38
Thanks kowey, for the rebase support!
msg15474 (view) Author: kowey Date: 2012-04-01.10:40:22
Nyet.

Not actually rebased.  I confused myself about the resolution, copying 
over just Owen's original.  Sigh
msg15488 (view) Author: kowey Date: 2012-04-01.14:37:40
Looks good, thanks for the cleanup.

That said, I'm not sure it's a good idea to move top-level helper 
function inside of where clauses. Seems like we want to aim for functions 
in small standalone-pieces, as in 
http://wiki.darcs.net/Development/Cleanup

No?
msg15490 (view) Author: kowey Date: 2012-04-01.14:39:02
Whoops, think it was patch785 that I accepted instead
History
Date User Action Args
2012-03-31 17:26:45owstcreate
2012-03-31 17:44:58koweysetstatus: needs-screening -> followup-requested
assignedto: owst
messages: + msg15458
2012-04-01 10:33:14koweysetfiles: + patch-preview.txt, layout_tidy-of-repository_hashedrepo.dpatch, unnamed
messages: + msg15470
2012-04-01 10:37:38owstsetmessages: + msg15471
2012-04-01 10:40:22koweysetmessages: + msg15474
2012-04-01 14:37:40koweysetstatus: followup-requested -> accepted
messages: + msg15488
2012-04-01 14:39:02koweysetstatus: accepted -> obsoleted
superseder: + Layout/tidy of Repository/HashedRepo (and 7 more)
messages: + msg15490