darcs

Patch 783 Remove a do-notation warning in URL. (and 15 more)

Title Remove a do-notation warning in URL. (and 15 more)
Superseder Nosy List owst
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-04-01.11:44:13 by owst, last changed 2012-04-01.11:46:51 by owst.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt owst, 2012-04-01.11:44:13 text/x-darcs-patch
remove-a-do_notation-warning-in-url_.dpatch owst, 2012-04-01.11:44:13 application/x-darcs-patch
unnamed owst, 2012-04-01.11:44:13
See mailing list archives for discussion on individual patches.
Messages
msg15480 (view) Author: owst Date: 2012-04-01.11:44:13
I've gone through and checked all the cases where we used to have warnings for
do-statements throwing away results, checking that it is ok to throw them away,
and using void in places where we had been doing '_ <- foo; return ()'

16 patches for repository http://darcs.net:

Sun Apr  1 11:08:07 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove a do-notation warning in URL.
  We are throwing away the threadID - we don't ever interact with the thread via
  its Id.

Sun Apr  1 11:18:49 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove two do-notation warnings in Repository
  In both cases, we want to fetch a given file from the cache, but don't care
  about the file contents.

Sun Apr  1 11:24:16 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove do-notation warning in RunCommand

Sun Apr  1 11:27:08 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove two do-notation warnings in Lock
  In the first case, we don't care if hClose fails, since we're already trying to
  cleanup. In the second, we don't care what exit code running the editor gave.

Sun Apr  1 11:30:41 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove two do-notation warnings in SignalHandler
  In both cases, we are discarding the old signal handler, which we don't care
  about.

Sun Apr  1 12:09:04 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove four do-notation warnings in Commands.Record

Sun Apr  1 12:11:35 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove do-notation warning in Commands.Tag

Sun Apr  1 12:14:38 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove two do-notation warnings from Commands.Optimize

Sun Apr  1 12:15:21 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * remove two do-notation warnings from Commands.Unrecord

Sun Apr  1 12:16:07 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove do-notation warning from Commands.Get

Sun Apr  1 12:23:15 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove do-notation warning from Repository.Internal

Sun Apr  1 12:24:26 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove do-notation warning from Repository.Merge

Sun Apr  1 12:37:59 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove do-notation warning from Repository.HashedIO

Sun Apr  1 12:39:04 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove do-notation warning from External

Sun Apr  1 12:41:49 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove do-notation warning from Compat

Sun Apr  1 12:42:10 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Remove do-notation warning from Workaround
Attachments
msg15482 (view) Author: owst Date: 2012-04-01.11:46:51
Self-accepting; mostly just removing comments and a few cases of
refactoring '_ <- foo; return ()' into 'void $ foo'
History
Date User Action Args
2012-04-01 11:44:13owstcreate
2012-04-01 11:46:51owstsetstatus: needs-screening -> accepted
messages: + msg15482