darcs

Patch 790 drop unnecessary call to joinPatches in ... (and 3 more)

Title drop unnecessary call to joinPatches in ... (and 3 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-04-01.18:01:22 by ganesh, last changed 2012-04-24.13:05:08 by gh.

Files
File name Status Uploaded Type Edit Remove
drop-unnecessary-call-to-joinpatches-in-darcs_repository_merge.dpatch ganesh, 2012-04-01.18:01:22 application/x-darcs-patch
patch-preview.txt ganesh, 2012-04-01.18:01:22 text/x-darcs-patch
unnamed ganesh, 2012-04-01.18:01:22
See mailing list archives for discussion on individual patches.
Messages
msg15504 (view) Author: ganesh Date: 2012-04-01.18:01:22
Some minor patch-related cleanups

4 patches for repository darcs-unstable@darcs.net:screened:

Wed Jan 12 18:23:11 GMT 2011  Ganesh Sittampalam <ganesh@earth.li>
  * drop unnecessary call to joinPatches in Darcs.Repository.Merge

Wed Jan 12 18:23:29 GMT 2011  Ganesh Sittampalam <ganesh@earth.li>
  * drop unnecessary call to joinPatches in Darcs.Resolution

Thu Jan 13 06:56:31 GMT 2011  Ganesh Sittampalam <ganesh@earth.li>
  * drop unnecessary superclasses from MyEq (PatchInfoAnd p)

Tue Jan 25 08:10:45 GMT 2011  Ganesh Sittampalam <ganesh@earth.li>
  * add a comment
Attachments
msg15608 (view) Author: ganesh Date: 2012-04-23.22:03:20
A couple of people have asked me on IRC what the joinPatches removal is about :-)

Dropping the calls to joinPatches is part of a general campaign to get rid of it as an 
unnecessary type class member; I did quite a lot of the work towards doing that in a 
series of patches cleaning up the patch code a couple of years ago, and this one was 
initially done as part of my rebase changes but turns out to stand alone.

In a later patch that will come once I find time to clean up the rebase branch, I expect 
to remove it completely from the FromPrims class.
msg15609 (view) Author: gh Date: 2012-04-24.13:05:08
Thanks for the explanation Ganesh! Accepted.
History
Date User Action Args
2012-04-01 18:01:22ganeshcreate
2012-04-23 22:03:21ganeshsetmessages: + msg15608
2012-04-24 13:05:08ghsetstatus: needs-screening -> accepted
messages: + msg15609