darcs

Patch 798 Tidy Repository.Merge (and 3 more)

Title Tidy Repository.Merge (and 3 more)
Superseder Nosy List owst
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-04-04.23:29:14 by owst, last changed 2012-04-24.13:17:05 by gh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt owst, 2012-04-04.23:29:14 text/x-darcs-patch
tidy-repository_merge.dpatch owst, 2012-04-04.23:29:14 application/x-darcs-patch
unnamed owst, 2012-04-04.23:29:14
See mailing list archives for discussion on individual patches.
Messages
msg15532 (view) Author: owst Date: 2012-04-04.23:29:14
A bunch of tidy ups.

4 patches for repository http://darcs.net:

Mon Apr  2 21:54:01 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Tidy Repository.Merge

Thu Apr  5 00:04:57 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Tidy/style Patch.Set

Thu Apr  5 00:20:58 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Use more informative identifier names in Patch.Set

Thu Apr  5 00:24:56 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Use haddock links in Patch.Set
Attachments
msg15534 (view) Author: owst Date: 2012-04-04.23:33:27
Simple tidy-up, self-accepting.
msg15611 (view) Author: gh Date: 2012-04-24.13:17:05
> Tidy Repository.Merge
OK, cleanup patch.

> Tidy/style Patch.Set
OK. Just a remark: usually now the module export list should be aligned
(ie, the opening and closing parentheses and commas) on the 5th column
(below the 'l' of 'module).

> Use more informative identifier names in Patch.Set
Nice one, gets rid of a couple of obscure short function names.

> Use haddock links in Patch.Set
Does what it says.
History
Date User Action Args
2012-04-04 23:29:14owstcreate
2012-04-04 23:33:27owstsetmessages: + msg15534
2012-04-11 21:54:32owstsetstatus: needs-screening -> needs-review
2012-04-24 13:17:05ghsetstatus: needs-review -> accepted
messages: + msg15611
2012-04-24 19:15:09owstlinkpatch809 superseder