darcs

Patch 820 make darcs apply work with url

Title make darcs apply work with url
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-05-14.17:41:43 by gh, last changed 2012-05-26.06:16:02 by kowey.

Files
File name Status Uploaded Type Edit Remove
haddock-for-fixurl-and-fix-2-haddocks.dpatch gh, 2012-05-25.01:58:07 application/octet-stream
make-darcs-apply-work-with-url.dpatch gh, 2012-05-14.17:41:42 application/octet-stream
See mailing list archives for discussion on individual patches.
Messages
msg15688 (view) Author: gh Date: 2012-05-14.17:41:42
Makes the following work:

darcs apply -i http://bugs.darcs.net/file3312/resolve-issue2186.dpatch
darcs apply -i http://bugs.darcs.net/file3312/

However the following does not work yet (would require a change in the
bug tracker):

darcs apply -i http://bugs.darcs.net/patch816
Attachments
msg15708 (view) Author: kowey Date: 2012-05-20.16:48:34
looks good

I think maybe we need a QC that ensures fixUrl is equivalent to 
fixFilePathOrStd when not given a URL
msg15713 (view) Author: gh Date: 2012-05-25.01:58:07
fixUrl cannot be equivalent to fixFilePathOrStd on non-URLs since
it doesn't handle the stdin case.

When not given an URL, fixUrl calls fixFilePath. I'm not really
motivated in writing a QC for that. I'm sending a haddock for fixUrl.
Attachments
History
Date User Action Args
2012-05-14 17:41:43ghcreate
2012-05-14 18:19:28ghsetstatus: needs-screening -> needs-review
2012-05-20 16:48:34koweysetstatus: needs-review -> accepted-pending-tests
messages: + msg15708
2012-05-25 01:58:07ghsetfiles: + haddock-for-fixurl-and-fix-2-haddocks.dpatch
messages: + msg15713
2012-05-26 06:16:02koweysetstatus: accepted-pending-tests -> accepted