darcs

Patch 839 move command-helping functions from Darc... (and 1 more)

Title move command-helping functions from Darc... (and 1 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-05-30.20:33:26 by gh, last changed 2012-05-31.23:29:45 by owst.

Files
File name Status Uploaded Type Edit Remove
move-command_helping-functions-from-darcs_arguments-to-darcs_commands.dpatch gh, 2012-05-30.20:33:26 application/x-darcs-patch
patch-preview.txt gh, 2012-05-30.20:33:26 text/x-darcs-patch
unnamed gh, 2012-05-30.20:33:26
See mailing list archives for discussion on individual patches.
Messages
msg15743 (view) Author: gh Date: 2012-05-30.20:33:26
The first patch moves to complicated function from Darcs.Arguments
to Darcs.Commands. The idea is that non-trivial stuff should gets
progressively out of Darcs.Arguments, which is doing much more stuff
than its name suggests.

The second patch is a change similar to the one that Petr Rockai did
in his "adventure" branch. It introduces the Darcs.Patch module
that replaces both Darcs.RepoPath and Darcs.Patch.FileName. The change
looks spectacular because it touches a lot of files, but no function
is really changed so don't be afraid.

The existence of both modules RepoPath and FileName is just a
consequence of a codebase growing organically over time.
Centralizing them in a single module will help up (in the future)
using an external library for path handling (Petr's pathlib for instance).

2 patches for repository http://darcs.net:

Sat May 26 19:40:13 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * move command-helping functions from Darcs.Arguments to Darcs.Commands

Sat May 26 21:41:57 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * introduce Darcs.Path to centralize path handling
  
  Replaces Darcs.Patch.FileName and Darcs.RepoPath
Attachments
msg15782 (view) Author: owst Date: 2012-05-31.23:29:45
Both look good - steps in the right direction, thanks!
History
Date User Action Args
2012-05-30 20:33:26ghcreate
2012-05-30 21:41:32ganeshsetstatus: needs-screening -> needs-review
2012-05-31 23:29:45owstsetstatus: needs-review -> accepted
messages: + msg15782