darcs

Patch 842 move pending-patch-writing writePatch to... (and 5 more)

Title move pending-patch-writing writePatch to... (and 5 more)
Superseder Nosy List gh
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-05-30.20:58:41 by gh, last changed 2012-05-31.23:53:09 by owst.

Files
File name Status Uploaded Type Edit Remove
move-pending_patch_writing-writepatch-to-darcs_repository_lowlevel.dpatch gh, 2012-05-30.20:58:41 application/x-darcs-patch
patch-preview.txt gh, 2012-05-30.20:58:41 text/x-darcs-patch
unnamed gh, 2012-05-30.20:58:41
See mailing list archives for discussion on individual patches.
Messages
msg15747 (view) Author: gh Date: 2012-05-30.20:58:41
Refactoring underway.

The idea is to try to fit top-level modules (Darcs.*)
into these submodules: Darcs.UI, Darcs.Patch, Darcs.Repository.

This sometimes require to split modules into several ones
(here External and Match). This forces us to wonder 'if there were
a {Patch|Repository} library, what kind of services should it
provide?' or 'should that function go into repository code, patch code
or UI code?'.

Eventually this will enable us to provide a cleaner
libdarcs, or even more fine-grained libraries ( patch and repo libraries).

6 patches for repository http://darcs.net:

Mon May 28 22:07:14 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * move pending-patch-writing writePatch to Darcs.Repository.LowLevel

Tue May 29 10:52:46 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * move Lock into Repository, merge IO into Repository.ApplyPatches

Tue May 29 11:12:38 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * introduce and populate the UI module, move Annotate into Patch

Tue May 29 11:13:28 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * move Resolution into Repository

Tue May 29 12:34:19 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * split External into Repository-specific and unspecific modules

Tue May 29 13:57:42 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
  * split Match in Repository-specific and Patch-specific modules
Attachments
msg15783 (view) Author: owst Date: 2012-05-31.23:53:09
> Mon May 28 22:07:14 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
>   * move pending-patch-writing writePatch to Darcs.Repository.LowLevel

Ok, this also removes gzWritePatch which is seemingly unused.

> Tue May 29 10:52:46 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
>   * move Lock into Repository, merge IO into Repository.ApplyPatches

Ok.

> Tue May 29 11:12:38 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
>   * introduce and populate the UI module, move Annotate into Patch

Does as it says.

> Tue May 29 11:13:28 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
>   * move Resolution into Repository

Ok

> Tue May 29 12:34:19 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
>   * split External into Repository-specific and unspecific modules

Ok

> Tue May 29 13:57:42 ART 2012  Guillaume Hoffmann <guillaumh@gmail.com>
>   * split Match in Repository-specific and Patch-specific modules

Ok, thanks!
History
Date User Action Args
2012-05-30 20:58:41ghcreate
2012-05-30 21:41:56ganeshsetstatus: needs-screening -> needs-review
2012-05-31 23:53:09owstsetstatus: needs-review -> accepted
messages: + msg15783