Patch 864 Resolve issue2204: do not send mail by default.

Title Resolve issue2204: do not send mail by default.
Superseder Nosy List kowey
Related Issues do not send email by default
View: 2204
Status accepted Assigned To kowey

Created on 2012-06-18.19:47:13 by kowey, last changed 2012-11-01.15:46:38 by darcswatch. Tracked on DarcsWatch.

File name Status Uploaded Type Edit Remove
fix-tests-that-were-broken-by-send-__mail-ui-change_.dpatch ganesh, 2012-08-26.00:55:16 text/x-darcs-patch
patch-preview.txt kowey, 2012-06-18.19:47:13 text/x-darcs-patch
resolve-issue2204_-do-not-send-mail-by-default_.dpatch kowey, 2012-06-18.19:47:13 application/x-darcs-patch
unnamed kowey, 2012-06-18.19:47:13
unnamed ganesh, 2012-08-26.00:55:16
See mailing list archives for discussion on individual patches.
msg15811 (view) Author: kowey Date: 2012-06-18.19:47:13
First: don't push this until we've had some UI thinking and discussion

Second: I'm not sure I dealt correctly with the default case filename
(getCurrentDirectory).  Thoughts?

1 patch for repository http://darcs.net:

Mon Jun 18 20:45:27 BST 2012  Eric Kow <kowey@darcs.net>
  * Resolve issue2204: do not send mail by default.
msg15935 (view) Author: kowey Date: 2012-08-02.16:10:07
I think I might as well screen this.  I'll post a note to darcs-users in 
case this helps us catch any UI points we may have missed
msg16018 (view) Author: ganesh Date: 2012-08-26.00:55:16
1 patch for repository /home/ganesh/darcs/darcs-screened-temp:

Sun Aug  5 16:37:08 BST 2012  Eric Kow <kowey@darcs.net>
  * Fix tests that were broken by send --mail UI change.
msg16019 (view) Author: darcswatch Date: 2012-08-26.00:56:09
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
msg16069 (view) Author: ganesh Date: 2012-09-09.15:35:06
My 2p worth: I hate this :-)

More constructively, the message

"To send it automatically, set up sendmail, and add 'send mail' in your 

has the problems that

(a) it probably isn't sendmail you need to setup - typically exim these 
days. It's just that sendmail is the "standard" interface they all 

(b) it doesn't say where the defaults are - ~/.darcs/defaults on unix, 
but somewhere else on Windows
msg16078 (view) Author: kowey Date: 2012-09-09.21:18:27
The current plan as I understand it is to make send --sendmail-command 
the trigger.  Just haven't gotten around to it (others are more than 
welcome to pick up the ball and run with it)
msg16267 (view) Author: galbolle Date: 2012-10-31.10:07:36
The consensus (as I gather from
is to remove that --mail option, and have the default be -O whenever
--sendmail-command is not set.
msg16280 (view) Author: darcswatch Date: 2012-11-01.15:46:38
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
Date User Action Args
2012-06-18 19:47:13koweycreate
2012-06-18 20:15:02ganeshsetstatus: needs-screening -> in-discussion
2012-08-02 16:10:07koweysetstatus: in-discussion -> needs-review
messages: + msg15935
issues: + do not send email by default
2012-08-26 00:55:16ganeshsetfiles: + fix-tests-that-were-broken-by-send-__mail-ui-change_.dpatch, unnamed
messages: + msg16018
2012-08-26 00:56:08darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-6a110c360ccc8136afa08f7b0658aa8eadcc01da
2012-08-26 00:56:09darcswatchsetmessages: + msg16019
2012-09-09 15:35:07ganeshsetmessages: + msg16069
2012-09-09 21:18:27koweysetmessages: + msg16078
2012-10-31 10:07:36galbollesetstatus: needs-review -> followup-requested
assignedto: kowey
messages: + msg16267
2012-11-01 15:46:38darcswatchsetstatus: followup-requested -> accepted
messages: + msg16280