Patch 890: Tighten up pending flag pattern matching. (and 3 more) - Darcs bug tracker

Title	Tighten up pending flag pattern matching. (and 3 more)
Superseder		Nosy List	kowey
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2012-08-04.19:33:14 by kowey, last changed 2012-09-29.21:17:27 by owst.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		kowey, 2012-08-04.19:33:13	text/x-darcs-patch
patch-preview.txt		kowey, 2012-08-05.15:45:06	text/x-darcs-patch
tidy-up-pending-formatting-and-hlintesque-issues-more_.dpatch		kowey, 2012-08-05.15:45:06	application/x-darcs-patch
tighten-up-pending-flag-pattern-matching_.dpatch		kowey, 2012-08-04.19:33:14	application/x-darcs-patch
unnamed		kowey, 2012-08-04.19:33:14
unnamed		kowey, 2012-08-05.15:45:06

See mailing list archives for discussion on individual patches.

Messages
msg15948 (view)	Author: kowey	Date: 2012-08-04.19:33:14
4 patches for repository http://darcs.net: Sat Aug 4 19:33:34 BST 2012 Eric Kow <kowey@darcs.net> * Tighten up pending flag pattern matching. We should avoid using catch-all (_) unless we really mean it. Better to have the compiler notice if we extend the UpdateToWorking type for whatever reason without accounting for the new case(s). Sat Aug 4 20:19:27 BST 2012 Eric Kow <kowey@darcs.net> * Try to comment and Haddock some prim patch stuff. Sat Aug 4 20:31:52 BST 2012 Eric Kow <kowey@darcs.net> * Tidy Darcs.Repository.Internal.siftForPending code style. Sat Aug 4 20:31:54 BST 2012 Eric Kow <kowey@darcs.net> * Commend and haddock a tiny bit of pending patch code. Attachments patch-preview.txt tighten-up-pending-flag-pattern-matching_.dpatch unnamed
msg15951 (view)	Author: kowey	Date: 2012-08-05.15:45:06
3 patches for repository http://darcs.net: Sun Aug 5 16:41:55 BST 2012 Eric Kow <kowey@darcs.net> * Tidy up pending formatting and hlintesque issues more. Sun Aug 5 16:41:57 BST 2012 Eric Kow <kowey@darcs.net> * Rename handlePendForAdd to tentativelyRemoveFromPending This could still be improved, it seems. We now have: * tentativelyRemoveFromPending (used by tentativelyAddPatches) * tentativelyAddToPending (exported) * prepend (used by tentativelyRemovePatches) Sun Aug 5 16:43:15 BST 2012 Eric Kow <kowey@darcs.net> * A few more comments and Haddock about the pending patch. Attachments patch-preview.txt tidy-up-pending-formatting-and-hlintesque-issues-more_.dpatch unnamed
msg16158 (view)	Author: owst	Date: 2012-09-29.21:17:27
All look good - accepting.

History
Date	User	Action	Args
2012-08-04 19:33:14	kowey	create
2012-08-05 15:45:07	kowey	set	files: + patch-preview.txt, tidy-up-pending-formatting-and-hlintesque-issues-more_.dpatch, unnamed messages: + msg15951
2012-08-26 00:26:03	ganesh	set	status: needs-screening -> needs-review
2012-09-29 21:17:27	owst	set	status: needs-review -> accepted messages: + msg16158