darcs

Patch 896 Make Darcs.Repository.isSimple apply ove... (and 4 more)

Title Make Darcs.Repository.isSimple apply ove... (and 4 more)
Superseder Nosy List kowey
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-08-09.15:54:52 by kowey, last changed 2015-11-20.22:25:07 by gh.

Files
File name Status Uploaded Type Edit Remove
make-darcs_repository_issimple-apply-over-a-whole-list_.dpatch kowey, 2012-08-09.15:54:52 application/x-darcs-patch
make-darcs_repository_issimple-apply-over-a-whole-list_.dpatch gh, 2015-11-20.22:23:22 application/x-darcs-patch
patch-preview.txt kowey, 2012-08-09.15:54:52 text/x-darcs-patch
patch-preview.txt gh, 2015-11-20.22:23:22 text/x-darcs-patch
unnamed kowey, 2012-08-09.15:54:52
unnamed gh, 2015-11-20.22:23:22 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg15965 (view) Author: kowey Date: 2012-08-09.15:54:52
5 patches for repository http://darcs.net:

I'm not screening this (although I encourage somebody else to if it makes sense
to them) because I don't know if I'm being stupid by wanting to rename things
so much so that they make more sense to me.

Thu Aug  9 09:15:42 BST 2012  Eric Kow <kowey@darcs.net>
  * Make Darcs.Repository.isSimple apply over a whole list.
  
  As far as I can tell, the notion of simplicity only really makes sense
  if it applies over an entire sequence of patches.

Thu Aug  9 09:29:46 BST 2012  Eric Kow <kowey@darcs.net>
  * Rename Darcs.Repository.LowLevel to Darcs.Repository.Pending.
  
  Everything in this module seems to be related to low-level pending
  patch details. Perhaps a future direction would be to move anything
  that directly manipulates the pending patch into this module and
  hide the low-level stuff.

Thu Aug  9 10:41:38 BST 2012  Eric Kow <kowey@darcs.net>
  * Rename Darcs.Repository.State.readRecordedAndPending to readRecordedCheckPending
  Bit of musical chairs here: also rename readPending to readRecordedAndPending.

Thu Aug  9 10:42:16 BST 2012  Eric Kow <kowey@darcs.net>
  * Haddock the pending patch parts of Darcs.Repository.State.

Thu Aug  9 16:48:19 BST 2012  Eric Kow <kowey@darcs.net>
  * Update some pending comments/haddock with revised understanding.
Attachments
msg15966 (view) Author: kowey Date: 2012-08-11.08:32:44
Don't apply

Rename Darcs.Repository.State.readRecordedAndPending to 
readRecordedCheckPending

I got confused.

Will resend when I understand better
msg18856 (view) Author: gh Date: 2015-11-20.22:23:22
I wanted to rename LowLevel as well and remembered Eric's bundle.
So I'm accepting the 3 following patches (the other two are trivial
and bring Haddock comments).

3 patches for repository http://darcs.net:

patch 7882917c73fb11155c9370427fa3b2ebff1d87a7
Author: Eric Kow <kowey@darcs.net>
Date:   Thu Aug  9 05:15:42 ART 2012
  * Make Darcs.Repository.isSimple apply over a whole list.
  
  As far as I can tell, the notion of simplicity only really makes sense
  if it applies over an entire sequence of patches.

patch 3ee5169b094f7ebade3b2230c70dfa78c2a4242d
Author: Eric Kow <kowey@darcs.net>
Date:   Thu Aug  9 06:42:16 ART 2012
  * Haddock the pending patch parts of Darcs.Repository.State.

patch 458b2df1c709268746514224a94dc68c37eb749f
Author: Guillaume Hoffmann <guillaumh@gmail.com>
Date:   Fri Nov 20 19:20:36 ART 2015
  * Rename Darcs.Repository.LowLevel to Darcs.Repository.Pending
  Original patch by Eric Kow.
Attachments
History
Date User Action Args
2012-08-09 15:54:52koweycreate
2012-08-11 08:32:44koweysetstatus: needs-screening -> rejected
messages: + msg15966
2015-11-20 22:23:23ghsetfiles: + patch-preview.txt, make-darcs_repository_issimple-apply-over-a-whole-list_.dpatch, unnamed
messages: + msg18856
2015-11-20 22:25:07ghsetstatus: rejected -> accepted