Patch 908: Escape nonprintable chars in darcs record - Darcs bug tracker

Title	Escape nonprintable chars in darcs record
Superseder		Nosy List	bfrk
Related Issues
Status	obsoleted	Assigned To	bfrk
Milestone

Created on 2012-08-19.06:25:28 by nand, last changed 2018-02-07.21:51:10 by gh.

Files
File name	Status	Uploaded	Type	Edit	Remove
escape-nonprintable-chars-in-darcs-record.dpatch		nand, 2012-08-19.06:25:27	application/x-darcs-patch
patch-preview.txt		nand, 2012-08-19.06:25:27	text/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg15990 (view)	Author: nand	Date: 2012-08-19.06:25:27
1 patch for repository http://darcs.net/screened: Sun Aug 19 06:41:05 CEST 2012 nand@lavabit.com * Escape nonprintable chars in darcs record Previously, darcs record would output mangled text when passed a patch name containing nonprintable characters. Note: I'm not sure if the implementation for failuremessage is correct since I don't know how to test it out. Attachments escape-nonprintable-chars-in-darcs-record.dpatch patch-preview.txt
msg15991 (view)	Author: kowey	Date: 2012-08-19.19:35:35
This seems fairly reasonable, the assumption I'm going on here that printing Doc's on screen does what we want wrt displaying non-printable chars to UI. Only technical comment I would add is that if we're going to use Doc's we might as well use the nice little functions like <> to build them up. Anyway, not a big deal. I think we should sweep up all our user text and put it into Darcs.UI.Message anyway, or something like that. nand: for the future, I think it's better to stick to plain old ASCII in the log messages (no fancy Unicode quotes, as much as I prefer them personally) and keep the messages short.
msg16272 (view)	Author: galbolle	Date: 2012-10-31.14:09:57
This now conflicts with screened.
msg19129 (view)	Author: gh	Date: 2016-04-01.20:27:18
Conflicting patches to watch out are: 0dab9957f34b9ae990e17eae4cbaf913ffad8808 997da2af6f44c6938d3b2d1296cadb6e78b08e47 Also 88a1662536df56fca0e315ba145129fc2bd896db which removes putDocLnWith and introduces hPutDocLnWith .
msg19838 (view)	Author: gh	Date: 2018-02-07.21:51:10
So many things happened in the meantime with encodings and escapings, this patch is most probably no longer relevant.

History
Date	User	Action	Args
2012-08-19 06:25:28	nand	create
2012-08-19 19:35:35	kowey	set	status: needs-screening -> accepted-pending-tests messages: + msg15991
2012-10-31 14:09:57	galbolle	set	status: accepted-pending-tests -> followup-requested assignedto: kowey messages: + msg16272 nosy: + kowey
2016-04-01 20:27:18	gh	set	nosy: + bfrk, - kowey, nand messages: + msg19129 assignedto: kowey -> bfrk
2018-02-07 21:51:10	gh	set	status: followup-requested -> obsoleted messages: + msg19838