darcs

Patch 912 Create Darcs.UI.Message hierarchy. (and 3 more)

Title Create Darcs.UI.Message hierarchy. (and 3 more)
Superseder Nosy List kowey
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-08-25.15:50:55 by kowey, last changed 2012-11-01.16:20:01 by galbolle.

Files
File name Status Uploaded Type Edit Remove
create-darcs_ui_message-hierarchy_.dpatch dead kowey, 2012-08-25.15:50:54 application/x-darcs-patch
create-darcs_ui_message-hierarchy_.dpatch kowey, 2012-08-25.15:53:04 application/x-darcs-patch
patch-preview.txt kowey, 2012-08-25.15:50:54 text/x-darcs-patch
patch-preview.txt kowey, 2012-08-25.15:53:04 text/x-darcs-patch
unnamed kowey, 2012-08-25.15:50:54
unnamed kowey, 2012-08-25.15:53:04
See mailing list archives for discussion on individual patches.
Messages
msg16004 (view) Author: kowey Date: 2012-08-25.15:50:54
Not sure if this would really be an improvement.
What do you think?

4 patches for repository http://darcs.net:

Sat Aug 25 16:45:03 BST 2012  Eric Kow <kowey@darcs.net>
  * Create Darcs.UI.Message hierarchy.
  
  The idea is to move all messages to the user into its own tree, hopefully
  making the Darcs code cleaner in the process and easier for users to help
  improve.

Sat Aug 25 16:46:59 BST 2012  Eric Kow <kowey@darcs.net>
  * Make Printer.Doc an IsString instance.
  
  This makes messages a bit more convenient to put together.

Sat Aug 25 16:47:44 BST 2012  Eric Kow <kowey@darcs.net>
  * Util.Text.sentence (appends a '.' to a Doc)

Sat Aug 25 16:48:27 BST 2012  Eric Kow <kowey@darcs.net>
  * Move darcs send messages to Darcs.UI.Message.
Attachments
msg16005 (view) Author: kowey Date: 2012-08-25.15:53:04
4 patches for repository http://darcs.net:

Oops, forgot a darcs add on the last patch

Sat Aug 25 16:45:03 BST 2012  Eric Kow <kowey@darcs.net>
  * Create Darcs.UI.Message hierarchy.
  
  The idea is to move all messages to the user into its own tree, hopefully
  making the Darcs code cleaner in the process and easier for users to help
  improve.

Sat Aug 25 16:46:59 BST 2012  Eric Kow <kowey@darcs.net>
  * Make Printer.Doc an IsString instance.
  
  This makes messages a bit more convenient to put together.

Sat Aug 25 16:47:44 BST 2012  Eric Kow <kowey@darcs.net>
  * Util.Text.sentence (appends a '.' to a Doc)

Sat Aug 25 16:51:44 BST 2012  Eric Kow <kowey@darcs.net>
  * Move darcs send messages to Darcs.UI.Message.
Attachments
msg16006 (view) Author: kowey Date: 2012-08-25.17:01:55
Guillaume cleared this for screened (I hesitated to self-screen because I 
wasn't sure it was actually a good idea, needed a 2nd opinion)
msg16190 (view) Author: owst Date: 2012-09-29.22:55:20
Yep, looks good, accepting. The first and last patches have deps on PI,
so can't push yet. Have pushed the other two.
msg16281 (view) Author: galbolle Date: 2012-11-01.16:20:01
These are in reviewed now.
History
Date User Action Args
2012-08-25 15:50:55koweycreate
2012-08-25 15:53:04koweysetfiles: + patch-preview.txt, create-darcs_ui_message-hierarchy_.dpatch, unnamed
messages: + msg16005
2012-08-25 17:01:55koweysetstatus: needs-screening -> needs-review
messages: + msg16006
2012-09-29 22:55:20owstsetstatus: needs-review -> accepted-pending-tests
messages: + msg16190
2012-11-01 16:20:01galbollesetstatus: accepted-pending-tests -> accepted
messages: + msg16281