darcs

Patch 930 Fix incorrect use of UI PatchInfo printing where disk ...

Title Fix incorrect use of UI PatchInfo printing where disk ...
Superseder Nosy List owst
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-09-02.23:45:29 by owst, last changed 2012-09-29.22:41:08 by owst.

Files
File name Status Uploaded Type Edit Remove
fix-incorrect-use-of-ui-patchinfo-printing-where-disk-format-is-required.dpatch owst, 2012-09-02.23:45:29 application/x-darcs-patch
patch-preview.txt owst, 2012-09-02.23:45:29 text/x-darcs-patch
unnamed owst, 2012-09-02.23:45:29
See mailing list archives for discussion on individual patches.
Messages
msg16053 (view) Author: owst Date: 2012-09-02.23:45:29
This is a follow up to patch927, which introduced a regression, but is already
screened.
1 patch for repository http://darcs.net/screened:

Mon Sep  3 00:39:04 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Fix incorrect use of UI PatchInfo printing where disk format is required
  The ShowPatch instantce for Named is used by Bundles, so until it's separated
  out, we can't use a different format
Attachments
msg16054 (view) Author: owst Date: 2012-09-02.23:48:43
This implies that there is further work to do, with regards to properly
separating out UI/disk printing functionality. It's *not* enough to
assume ShowPatchBasic is for disk and ShowPatch is for UI (which I had
done, hence this patch was required)
msg16181 (view) Author: owst Date: 2012-09-29.22:41:08
Self accepting
History
Date User Action Args
2012-09-02 23:45:29owstcreate
2012-09-02 23:45:50owstsetstatus: needs-screening -> needs-review
2012-09-02 23:48:43owstsetmessages: + msg16054
2012-09-29 22:41:08owstsetstatus: needs-review -> accepted
messages: + msg16181