darcs

Patch 955 Tidy/Style Repository/Prefs (and 2 more)

Title Tidy/Style Repository/Prefs (and 2 more)
Superseder Nosy List ganesh, owst
Related Issues
Status accepted Assigned To
Milestone

Created on 2012-09-29.19:16:56 by owst, last changed 2012-12-21.17:11:35 by owst.

Files
File name Status Uploaded Type Edit Remove
need-to-treat-paths-in-prefs_binaries-as-posix_-even-on-windows.dpatch ganesh, 2012-12-20.06:54:18 application/x-darcs-patch
patch-preview.txt owst, 2012-09-29.19:16:56 text/x-darcs-patch
patch-preview.txt ganesh, 2012-12-20.06:54:18 text/x-darcs-patch
tidy_style-repository_prefs.dpatch owst, 2012-09-29.19:16:56 application/x-darcs-patch
unnamed owst, 2012-09-29.19:16:56
unnamed ganesh, 2012-12-20.06:54:18
See mailing list archives for discussion on individual patches.
Messages
msg16142 (view) Author: owst Date: 2012-09-29.19:16:56
3 patches for repository http://darcs.net:

Sat Sep 29 20:19:08 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Tidy/Style Repository/Prefs

Sat Sep 29 20:19:13 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * resolve issue2246 - add default boring entry for emacs session save files

Sat Sep 29 20:19:13 BST 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Implement Repository/Prefs.normalise in terms of standard FilePath functions
Attachments
msg16150 (view) Author: owst Date: 2012-09-29.20:42:38
A simple tidy up, adding a default boring entry, and remove a
reimplemented library function. This also depends on a bunch of stuff
not in reviewed.
msg16211 (view) Author: ganesh Date: 2012-10-04.23:55:56
darcs test says that this patch breaks the binary_prefs test on Windows. I'll check on the details later, just rolling this 
back to needs-review for now.

Sat Sep 29 19:19:13 Coordinated Universal Time 2012  Owen Stephens <darcs@owenstephens.co.uk>
  * Implement Repository/Prefs.normalise in terms of standard FilePath functions

prefs_binary.sh (Hashed): [Failed]
| rm -rf temp1
| + rm -rf temp1
|
| mkdir temp1
| + mkdir temp1
| cd temp1
| + cd temp1
| darcs init
| + darcs init
| mkdir d
| + mkdir d
| touch d/t.t
| + touch d/t.t
| darcs add d/t.t
| + darcs add d/t.t
| darcs record -am "initial record"
| + darcs record -am 'initial record'
| Finished recording patch 'initial record'
| echo 'some change' >> d/t.t
| + echo 'some change'
| echo ny | darcs record --interactive > log
| + echo ny
| + darcs record --interactive
| # pre-test: plain text files are not binary
| not grep binary log
| + not grep binary log
| + grep binary log
| + :
| echo 'd/t' >>  _darcs/prefs/binaries
| + echo d/t
| echo ny | darcs record --interactive > log
| + echo ny
| + darcs record --interactive
| grep binary log
| + grep binary log
msg16366 (view) Author: owst Date: 2012-11-12.01:55:17
I pushed the first 2 patches to reviewed
msg16442 (view) Author: ganesh Date: 2012-12-20.06:54:18
This tweak fixes the prefs_binary test: otherwise / in a filename
was being turned into \, whereas the curent expectation is that
_darcs/prefs/binary contains /s.

1 patch for repository darcs-unstable@darcs.net:screened:

Thu Dec 20 06:46:00 GMT 2012  Ganesh Sittampalam <ganesh@earth.li>
  * need to treat paths in prefs/binaries as Posix, even on Windows
Attachments
msg16467 (view) Author: owst Date: 2012-12-21.17:11:35
Ganesh's patch fixes the outlying issue with this patch, so I'm
accepting this lot.
History
Date User Action Args
2012-09-29 19:16:56owstcreate
2012-09-29 19:17:41owstlinkpatch954 superseder
2012-09-29 20:42:38owstsetstatus: needs-screening -> accepted-pending-tests
messages: + msg16150
2012-10-04 23:55:57ganeshsetstatus: accepted-pending-tests -> needs-review
nosy: + ganesh
messages: + msg16211
2012-11-12 01:55:17owstsetmessages: + msg16366
2012-12-20 06:54:18ganeshsetfiles: + patch-preview.txt, need-to-treat-paths-in-prefs_binaries-as-posix_-even-on-windows.dpatch, unnamed
messages: + msg16442
2012-12-21 17:11:35owstsetstatus: needs-review -> accepted
messages: + msg16467