Patch 970: Resolve issue1332 for good - Darcs bug tracker

Created on 2012-11-08.11:46:40 by galbolle, last changed 2012-11-10.23:40:56 by owst.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		galbolle, 2012-11-08.11:46:40	text/x-darcs-patch
patch-preview.txt		owst, 2012-11-08.13:44:59	text/x-darcs-patch
resolve-issue1332-for-good.dpatch		galbolle, 2012-11-08.11:46:40	application/x-darcs-patch
resolve-issue1332-for-good.dpatch		owst, 2012-11-08.13:44:59	application/x-darcs-patch
unnamed		galbolle, 2012-11-08.11:46:40
unnamed		owst, 2012-11-08.13:44:59

See mailing list archives for discussion on individual patches.

Messages
msg16316 (view)	Author: galbolle	Date: 2012-11-08.11:46:40
1 patch for repository darcs-unstable@darcs.net:screened: Tue Nov 6 21:07:59 CET 2012 Florent Becker <florent.becker@ens-lyon.org> * Resolve issue1332 for good Attachments patch-preview.txt resolve-issue1332-for-good.dpatch unnamed
msg16319 (view)	Author: owst	Date: 2012-11-08.13:42:51
This patch adds a couple of warnings: src/Darcs/UI/Commands/Add.hs:172:9: Warning: Defined but not used: `nf' src/Darcs/UI/Commands/Add.hs:335:12: Warning: This binding for `includeBoring' shadows the existing binding imported from `Darcs.UI.Flags' at src/Darcs/UI/Commands/Add.hs:66:25-37 (and originally defined at src/Darcs/UI/Flags.hs:267:1-13) src/Darcs/UI/Commands/Add.hs:343:11: Warning: This binding for `includeBoring' shadows the existing binding imported from `Darcs.UI.Flags' at src/Darcs/UI/Commands/Add.hs:66:25-37 (and originally defined at src/Darcs/UI/Flags.hs:267:1-13) src/Darcs/UI/Commands/Add.hs:344:11: Warning: This binding for `includeBoring' shadows the existing binding imported from `Darcs.UI.Flags' at src/Darcs/UI/Commands/Add.hs:66:25-37 (and originally defined at src/Darcs/UI/Flags.hs:267:1-13) <no location info>: Failing due to -Werror. I'll send an updated bundle with the amended patch, otherwise it looks fine, all tests pass.
msg16320 (view)	Author: owst	Date: 2012-11-08.13:44:59
Tweaked to remove warnings. 1 patch for repository http://www.darcs.net: Thu Nov 8 13:42:10 GMT 2012 Florent Becker <florent.becker@ens-lyon.org> * Resolve issue1332 for good Attachments patch-preview.txt resolve-issue1332-for-good.dpatch unnamed

History
Date	User	Action	Args
2012-11-08 11:46:40	galbolle	create
2012-11-08 13:42:51	owst	set	messages: + msg16319
2012-11-08 13:44:59	owst	set	files: + patch-preview.txt, resolve-issue1332-for-good.dpatch, unnamed messages: + msg16320
2012-11-10 23:40:56	owst	set	status: needs-screening -> accepted