With darcs 1 we could send patches with more context which is nice when
reviewing patches using --unified with the darcs send command.  With Darcs 2
this feature was lost.  Would it be simple to add it again?

Hi David,

On Mon, Oct 06, 2008 at 15:07:23 -0000, David Leuschner wrote:
> With darcs 1 we could send patches with more context which is nice when
> reviewing patches using --unified with the darcs send command.  With Darcs 2
> this feature was lost.  Would it be simple to add it again?

As I understand it, this feature was not lost.  Instead, it has become
the default, which is why the switch no longer exists.

Do you have an example of darcs 2 not showing the surrounding diff
context?

Thanks!

Hi Eric,

> As I understand it, this feature was not lost.  Instead, it has become
> the default, which is why the switch no longer exists.
> 
> Do you have an example of darcs 2 not showing the surrounding diff
> context?

I'm using darcs 2 on my development machine.  The system with the main
repository I'm creating the patch for is running darcs 1.  Might that be
the problem?  I've just created a patch which, as a email, looks like
this:

...
> [-- Attachment #2: A darcs patch for your repository! --]
> [-- Type: text/x-darcs-patch, Encoding: quoted-printable, Size: 94K --]
> Content-Type: text/x-darcs-patch; name="feature_-fixeinsätze.dpatch"
> Content-Transfer-Encoding: quoted-printable
> Content-Description: A darcs patch for your repository!
> 
> 
> New patches:
> 
> [FEATURE: Fixeins?tze
> David Leuschner <david@loisch.de>**20081006144920] {
> hunk ./db/setup-tables.sql 649
> +  fix           BOOLEAN         NOT NULL DEFAULT FALSE,
> hunk ./db/setup-views.sql 112
> +            tpl.fix,
> hunk ./db/setup-views.sql 148
> -            ) AS abw_uebern_durch
> +            ) AS abw_uebern_durch,
> +            tpl1.fix        AS fix
> hunk ./db/setup-views.sql 180
> -            NULL::INTEGER   AS abw_uebern_durch
> +            NULL::INTEGER   AS abw_uebern_durch,

Thank you for your instant response! :-)

      David

Hi David,

Thanks for the details! I'm adding David Roundy to this because he made
--unified the default and also deferring to Thorkil for further issue managing.

Cheers,

This is fixed in darcs 2.1pre.

David

Thanks everybody. There is still the matter of the description on http://www.darcs.net/manual/node3.html 
under the heading "Submitting patches to darcs" that mentions the -u flag. I'm afraid I don't know where that 
originates (so I won't change the status of this issue), but it would be nice if that were taken care of, it 
actually confused me earlier today.

Thanks and best regards
Thorkil

> This is fixed in darcs 2.1pre.

Thanks!  I'm now using 2.1pre3.

Cheers, David

On Mon, Oct 06, 2008 at 06:46:15PM -0000, Thorkil Naur wrote:
> Thanks everybody. There is still the matter of the description on
> http://www.darcs.net/manual/node3.html under the heading "Submitting
> patches to darcs" that mentions the -u flag. I'm afraid I don't know
> where that originates (so I won't change the status of this issue),
> but it would be nice if that were taken care of, it actually
> confused me earlier today.

You can use grep to find it.

David

Setting as resolved based on the following.

Best regards
Thorkil
On Wednesday 15 October 2008 16:08, David Roundy wrote:
> On Wed, Oct 15, 2008 at 09:59:04AM +0200, Thorkil Naur wrote:
> > Wed Oct 15 09:37:51 CEST 2008  Thorkil Naur <naur@post11.tele.dk>
> >   * fix Submitting patches to darcs with respect to send -u
> 
> Applied, thanks!
> 
> David
> _______________________________________________
> darcs-users mailing list
> darcs-users@darcs.net
> http://lists.osuosl.org/mailman/listinfo/darcs-users
>