darcs

Issue 1255 darcs put tries to convert to darcs-2-format?

Title darcs put tries to convert to darcs-2-format?
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List benmos, darcs-devel, dmitry.kurochkin, jaredj, kowey, thorkilnaur, zooko
Assigned To
Topics ProbablyEasy

Created on 2008-12-05.12:37:14 by zooko, last changed 2009-08-27.14:16:11 by admin.

Messages
msg6774 (view) Author: zooko Date: 2008-12-05.12:37:11
When I do a darcs put of a darcs-1-format repo over ssh to a remote server, it
looks like it tries to make the new target repo be darcs-2-format:

zooko@hanford:~/server$ time darcs put  -v -v -v --debug --timing
zooko@allmydata.org:putserver-test 2>&1 | tee zooko.put.log.txt
Fri Dec  5 04:34:45 PST 2008: Creating repository
Fri Dec  5 04:34:45 PST 2008: Beginning identifying repository .
Fri Dec  5 04:34:45 PST 2008: Done identifying repository .
Fri Dec  5 04:34:45 PST 2008: ssh zooko@allmydata.org darcs initialize
--repodir='putserver-test' 
Fri Dec  5 04:34:45 PST 2008: Disabling progress reports...
Fri Dec  5 04:34:45 PST 2008: Reenabling progress reports.
Fri Dec  5 04:34:45 PST 2008: Beginning identifying repository .
Fri Dec  5 04:34:45 PST 2008: Done identifying repository .
Fri Dec  5 04:34:45 PST 2008: Identified darcs-1 repo: /home/zooko/server
Fri Dec  5 04:34:45 PST 2008: Beginning reading inventory of repository
/home/zooko/server
Fri Dec  5 04:34:45 PST 2008: Beginning reading inventory of repository
/home/zooko/server
Fri Dec  5 04:34:45 PST 2008: Done reading inventory of repository
/home/zooko/server
Fri Dec  5 04:34:45 PST 2008: Disabling progress reports...
Fri Dec  5 04:34:45 PST 2008: ssh zooko@allmydata.org darcs apply --all --debug
--repodir 'putserver-test'
Beginning identifying repository .
Done identifying repository .
Identified darcs-2 repo: /home/zooko/putserver-test

(Note that /home/zooko/putserver-test did not exist before this command was run.)

If I let that command run for a long time it will yield strange errors claiming
that patches are ill-formed.  In contrast if I add "--hashed" or
"--old-fashioned" to the command line then it emits:

zooko@hanford:~/server$ time darcs put --old-fashioned -v -v -v --debug --timing
zooko@allmydata.org:putserver-old 2>&1 | tee zooko.put.log.txt
...
Fri Dec  5 04:34:23 PST 2008: ssh zooko@allmydata.org darcs apply --all --debug
--repodir 'putserver-old'
Beginning identifying repository .
Done identifying repository .
Identified darcs-1 repo: /home/zooko/putserver-old
msg6777 (view) Author: zooko Date: 2008-12-05.13:01:45
Here's the error that I promised:

zooko@hanford:~/server$ time darcs put  -v -v -v --debug --timing
zooko@allmydata.org:putserver-test2 2>&1 | tee zooko.put.log.txt
Fri Dec  5 04:38:18 PST 2008: Creating repository
Fri Dec  5 04:38:18 PST 2008: Beginning identifying repository .
Fri Dec  5 04:38:18 PST 2008: Done identifying repository .
Fri Dec  5 04:38:18 PST 2008: ssh zooko@allmydata.org darcs initialize
--repodir='putserver-test2' 
Fri Dec  5 04:38:18 PST 2008: Disabling progress reports...
Fri Dec  5 04:38:19 PST 2008: Reenabling progress reports.
Fri Dec  5 04:38:19 PST 2008: Beginning identifying repository .
Fri Dec  5 04:38:19 PST 2008: Done identifying repository .
Fri Dec  5 04:38:19 PST 2008: Identified darcs-1 repo: /home/zooko/server
Fri Dec  5 04:38:19 PST 2008: Beginning reading inventory of repository
/home/zooko/server
Fri Dec  5 04:38:19 PST 2008: Beginning reading inventory of repository
/home/zooko/server
Fri Dec  5 04:38:19 PST 2008: Done reading inventory of repository
/home/zooko/server
Fri Dec  5 04:38:19 PST 2008: Disabling progress reports...
Fri Dec  5 04:38:19 PST 2008: ssh zooko@allmydata.org darcs apply --all --debug
--repodir 'putserver-test2'
Beginning identifying repository .
Done identifying repository .
Identified darcs-2 repo: /home/zooko/putserver-test2

darcs failed:  Malformed patch bundle: '{' is not 'Context:'
msg7094 (view) Author: zooko Date: 2009-01-14.21:30:18
It looks like issue1217 might be related.
msg7101 (view) Author: kowey Date: 2009-01-15.09:01:26
I think this should be fairly easy to fix (we need to pass along the
--old-fashioned flag to darcs put)... I'll bet that we used to have code to
intelligently detect if we need to pass along the --darcs-2 flag to darcs apply
(back before --darcs-2 repos were default), and that we can just re-arrange it so.
msg7397 (view) Author: kowey Date: 2009-03-04.15:10:36
Hi Ben,

Would you like to try this one out?  This would fix a really annoying bug with
darcs put and old-fashioned (or hashed) repositories.  Feel free to un-assign
yourself.

Thanks!
msg7477 (view) Author: kowey Date: 2009-03-18.20:19:30
Actually, David has recently fixed this in his patch:
Sat Feb 14 21:46:40 GMT 2009  David Roundy <droundy@darcs.net>
  * fix bug in put of darcs-1 format repositories.
History
Date User Action Args
2008-12-05 12:37:14zookocreate
2008-12-05 13:01:47zookosetstatus: unread -> unknown
nosy: kowey, zooko, dagit, simon, thorkilnaur, dmitry.kurochkin
messages: + msg6777
2009-01-14 21:30:20zookosetnosy: kowey, zooko, dagit, simon, thorkilnaur, dmitry.kurochkin
messages: + msg7094
2009-01-15 09:01:30koweysettopic: + ProbablyEasy
nosy: + jaredj
messages: + msg7101
2009-01-15 09:03:38koweylinkissue1217 superseder
2009-03-04 15:10:39koweysetnosy: + benmos
messages: + msg7397
assignedto: benmos
2009-03-18 20:19:38koweysetstatus: unknown -> resolved
nosy: kowey, zooko, dagit, simon, thorkilnaur, jaredj, dmitry.kurochkin, benmos
messages: + msg7477
assignedto: benmos ->
2009-08-10 23:52:50adminsetnosy: - dagit
2009-08-25 17:35:39adminsetnosy: + darcs-devel, - simon
2009-08-27 14:16:11adminsetnosy: kowey, darcs-devel, zooko, thorkilnaur, jaredj, dmitry.kurochkin, benmos