darcs

Issue 1382 darcs apply: darcs: bug in get_extra commuting patches

Title darcs apply: darcs: bug in get_extra commuting patches
Priority urgent Status wont-fix
Milestone Resolved in
Superseder patch bundle hash check not done early enough to detect corruption
View: 1521
Nosy List darcs-devel, dmitry.kurochkin, kowey, mornfall, thorkilnaur
Assigned To
Topics

Created on 2009-03-07.08:52:38 by mornfall, last changed 2009-08-27.14:24:06 by admin.

Messages
msg7412 (view) Author: mornfall Date: 2009-03-07.08:52:34
Trying to apply a patch bundle:

First patch is:
Wed Jan  7 15:19:47 CET 2009  Petr Rockai <me@mornfall.net>
  * Skeleton mpiThread that will eventually provide the remote/local interface.
Second patch is:
Wed Feb  4 14:44:48 CET 2009  Petr Rockai <me@mornfall.net>
  * Semi-large internals refactor for code clarity. No functional change.

To reproduce:
darcs get http://divine.fi.muni.cz/darcs/branch-2.0
wget http://web.mornfall.net/stuff/use-data_storable-in-the-ffi-interface-and-
benchmarkhs_.dpatch

darcs apply the dpatch.

I really don't understand why it's trying to commute the patches, since they 
appear in same order in both the original repository and in the patch bundle.

Probably a genuine bug in get_extra (and not in commutation). The latter patch 
depends on the former, anyway, so the commutation *should not* succeed, 
actually. Why it is trying that is beyond me (see above -- the patches appear 
in same order in both contexts).
msg7413 (view) Author: mornfall Date: 2009-03-07.13:08:06
I have tracked this down to possible patch bundle corruption: a couple lines in 
the bundle context have acquired an extra final period. That's all, removing 
those makes the patch apply cleanly.

I'm like totally thrown off.

Also, something nasty is going on with bundle hash checking (I think I have 
commented elsewhere that the check is done way too late... so probably this is 
tha case, too).
msg8143 (view) Author: mornfall Date: 2009-08-14.21:56:11
I think this is basically superseded by issue1521 -- this bug in itself is not
really a bug, just a side-effect of the too-late hash check.
History
Date User Action Args
2009-03-07 08:52:38mornfallcreate
2009-03-07 08:52:57mornfallsetnosy: kowey, simon, thorkilnaur, dmitry.kurochkin, mornfall
title: darcs: bug in get_extra commuting patches -> darcs apply: darcs: bug in get_extra commuting patches
2009-03-07 13:08:09mornfallsetstatus: unread -> unknown
nosy: kowey, simon, thorkilnaur, dmitry.kurochkin, mornfall
messages: + msg7413
2009-08-14 21:56:14mornfallsetstatus: unknown -> wont-fix
nosy: kowey, simon, thorkilnaur, dmitry.kurochkin, mornfall
superseder: + patch bundle hash check not done early enough to detect corruption
messages: + msg8143
2009-08-25 17:41:45adminsetnosy: + darcs-devel, - simon
2009-08-27 14:24:06adminsetnosy: kowey, darcs-devel, thorkilnaur, dmitry.kurochkin, mornfall