darcs

Issue 1660 patch viewing should either always/never use the pager in changes -i

Title patch viewing should either always/never use the pager in changes -i
Priority bug Status resolved
Milestone Resolved in 2.5.0
Superseder Nosy List darcs-devel, dmitry.kurochkin, jaredj, kowey, thorkilnaur, tommy, warner-darcs-bugs
Assigned To
Topics ProbablyEasy, UI

Created on 2009-10-25.21:54:42 by admin, last changed 2010-12-08.22:27:50 by kerneis.

Messages
msg9033 (view) Author: warner-darcs-bugs Date: 2009-10-25.21:25:32
Thanks for the summary! I should point out that I've gotten used to this
feature, so I don't mind it very much anymore (possibly because I've been using
git a lot, although I've noticed that git always uses a pager for the verbose
--help output and never for the terse -h usage summary, and the -h summary
usually fits in 10 or 15 lines, which seems to be a good compromise).

It may be more appropriate for a different bug, but I'll mention that the aspect
of this pager thing which really does bother me about darcs is the inconsistency
of using a pager for other output, specifically when viewing patches with "darcs
changes -i". Sometimes when I hit "y" to view a patch, I then need to hit "q" to
return to the summary, but sometimes when I hit "q" it quits darcs altogether.
Frustrating.
msg9037 (view) Author: kowey Date: 2009-10-25.22:01:46
Hi Brian,

Thanks for the comment!  I've created a new bug for this issue.  The underlying
problem, if I understand correctly, is that we're using a viewDocWithPager
function which only triggers when we think the patch is over a screenful.  As
Brian points out, this can be very confusing during interactive dialogues where
you seemingly randomly interleave the behaviour.

I personally vote we remove the use of the pager here, and just
- make the 'p' option work for changes -i
- make the default viewing command never use the pager
- verify that commands that display patches also avoid the pager

This should be very easy for anybody to implement, just swap out one of our
patch viewing functions with another.  It's probably the SelectChanges module
you'd want to look at.
msg13299 (view) Author: kerneis Date: 2010-12-08.22:27:49
This is fixed since 2.5 (at least).
History
Date User Action Args
2009-10-25 21:54:42admincreate
2009-10-25 22:01:53koweysetstatus: unknown -> needs-implementation
priority: bug
title: patch viewing should either always/never use the pager in changes -i
nosy: + jaredj
messages: + msg9037
topic: + ProbablyEasy, UI
2010-12-08 22:27:50kerneissetstatus: needs-implementation -> resolved
messages: + msg13299
resolvedin: 2.5.0