darcs

Issue 1671 Patch bundle failed hash! -- tell me the expected hash

Title Patch bundle failed hash! -- tell me the expected hash
Priority feature Status wont-fix
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, twb
Assigned To
Topics

Created on 2009-11-01.07:50:14 by twb, last changed 2009-11-02.08:19:36 by kowey.

Messages
msg9157 (view) Author: twb Date: 2009-11-01.07:50:10
Shortly after tediously importing about thirty historical changesets
by hand, I realized I had imported the changes into the wrong
directory.

In such cases in the past, I have successfuly editing files in
_darcs/patches/ directly, but this time I thought I'd be clever,
serialize the patch bundle using darcs send -aO, and edit that.

That went perfectly, and as expected the hash didn't match anymore.  I
tried to apply it with --debug and --verbose, expecting Darcs to tell
me what the patch SHOULD be, so I could simply edit the hash at the
bottom of the patch bundle.  But Darcs didn't tell me, so I'll have to
spend another four hours tediously re-importing them.  Grr!
msg9167 (view) Author: kowey Date: 2009-11-01.19:28:57
Why not just delete the hash?
msg9176 (view) Author: twb Date: 2009-11-02.00:59:12
On Sun, Nov 01, 2009 at 07:28:59PM +0000, Eric Kow wrote:
> Why not just delete the hash?

I didn't realize that darcs apply would blithely carry on if it found
no hash.  Maybe, then, this fact should be documented on a "doing
Wrong Things in Darcs" page on the wiki?
msg9177 (view) Author: twb Date: 2009-11-02.04:24:18
You're right -- patch37 wouldn't apply due to a hash mismatch, and
just deleting the hash made darcs go ahead and apply it.
msg9181 (view) Author: kowey Date: 2009-11-02.08:19:34
I'd like to make this a wont-fix then, to avoid users being tempted to shoot
themselves in the foot.  

An evil FAQ on the wiki wouldn't be bad if worded carefully and also crafted not
to run into the eyes-glazing-over effect.  "You do NOT want to do these things.
 Check with darcs-users first".  People have a funny habit of thinking the evil
FAQ stuff applies to them... (but it's probably better for us to control the
Evil FAQ rather than let it come from folklore)
History
Date User Action Args
2009-11-01 07:50:14twbcreate
2009-11-01 19:28:59koweysetpriority: feature
nosy: + kowey
messages: + msg9167
2009-11-02 00:59:14twbsetmessages: + msg9176
2009-11-02 04:24:19twbsetmessages: + msg9177
2009-11-02 08:19:36koweysetstatus: unknown -> wont-fix
messages: + msg9181