darcs

Issue 1715 changes --only-to-files produces bogus xml with --summary

Title changes --only-to-files produces bogus xml with --summary
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, fx, kowey
Assigned To
Topics Regression, UI

Created on 2009-12-11.14:09:45 by fx, last changed 2009-12-14.11:33:08 by kowey.

Messages
msg9595 (view) Author: fx Date: 2009-12-11.14:09:41
Consider this:

  $ darcs changes --max-count 1 --summary --only-to-files haskell-mode.el
  Changes to haskell-mode.el:
  
  Fri Nov 20 20:18:38 GMT 2009  Dave Love <fx@gnu.org>
    * Add :group to haskell-check-command.
  
      <modify_file>
      haskell-mode.el<added_lines num='1'/>
      </modify_file>

in contrast to:

  $ darcs changes --max-count 1 --summary
  Fri Nov 20 20:18:38 GMT 2009  Dave Love <fx@gnu.org>
    * Add :group to haskell-check-command.
  
      M ./haskell-mode.el +1
  $ 

It doesn't happen with Ubuntu's version 2.2.0 (eliding --max-count,
which is a later addition), but does with a 2.3.1+ built from the
current repo.
msg9596 (view) Author: kowey Date: 2009-12-11.14:35:56
On Fri, Dec 11, 2009 at 14:09:46 +0000, Dave Love wrote:
>   $ darcs changes --max-count 1 --summary --only-to-files haskell-mode.el
>   Changes to haskell-mode.el:
>   
>   Fri Nov 20 20:18:38 GMT 2009  Dave Love <fx@gnu.org>
>     * Add :group to haskell-check-command.
>   
>       <modify_file>
>       haskell-mode.el<added_lines num='1'/>
>       </modify_file>

Does http://bugs.darcs.net/patch108 fix this for you?

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg9597 (view) Author: fx Date: 2009-12-11.21:15:37
Eric Kow <bugs@darcs.net> writes:

> Does http://bugs.darcs.net/patch108 fix this for you?

Yes.  (Sorry, I should have sent my report in earlier.)
msg9619 (view) Author: kowey Date: 2009-12-14.11:33:02
Presumably resolved by:
Tue Dec  8 15:15:45 GMT 2009  Eric Kow <kowey@darcs.net>
  * Fix regression in interactive UI patch summary.
  I confused a False with a True in my attempt at refactoring this code.
History
Date User Action Args
2009-12-11 14:09:45fxcreate
2009-12-11 14:36:00koweysetnosy: + kowey
messages: + msg9596
2009-12-11 14:36:13koweylinkpatch108 issues
2009-12-11 21:15:41fxsetmessages: + msg9597
2009-12-12 01:00:21koweysetpriority: bug
status: unknown -> has-patch
2009-12-14 11:33:08koweysetstatus: has-patch -> resolved
topic: + UI, Regression
messages: + msg9619