darcs

Issue 185 darcs changes -s should show both adds andremoves

Title darcs changes -s should show both adds andremoves
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List bsoto, darcs-devel, dmitry.kurochkin, eschnett, kowey, lele, thorkilnaur, tommy
Assigned To
Topics ProbablyEasy

Created on 2006-06-08.00:24:46 by bsoto, last changed 2009-08-27.13:49:06 by admin.

Messages
msg701 (view) Author: bsoto Date: 2006-06-08.00:24:44
Quoted from Tommy Pettersson:
'Changes -v' shows both adds and removes, but 'Changes -s' shows
only the removes, so something is at least inconsistent.

and

The simples and safest solution looks like making changes -s
show both A and R.

For context:
http://www.abridgegame.org/pipermail/darcs-users/2006-May/010033.html
and
http://www.abridgegame.org/pipermail/darcs-users/2006-June/010035.html
msg905 (view) Author: simon Date: 2006-08-15.10:34:00
I seem to see this working fine in stable 1.0.8 on gnu/linux. I haven't been
able to pinpoint any change that fixed it though.
msg920 (view) Author: lele Date: 2006-08-18.20:19:42
See the case explained in http://progetti.arstecnica.it/tailor/ticket/71 
I'm afraid it's much easier fixing darcs than writing a workaround in 
tailor...
msg922 (view) Author: eschnett Date: 2006-08-18.21:35:05
This error seems to be caused by PatchViewing::gen_summary.  Its sub-function 
"combine" combines patches if they relate to the same file.  An AddFile and a 
RmFile will be combined.

AddFile is represented by an Int triple (-1,0,0), RmFile by (0,-1,0).  The 
combined triple is (-1,-1,0).  The definition of summ later on matches this as 
RmFile.

I think that there should be either a separate case for an add and remove at the 
same time, or this combination should not be combined in the first place.
msg1761 (view) Author: tommy Date: 2007-06-29.19:39:17
fixed in 1.0.9
History
Date User Action Args
2006-06-08 00:24:46bsotocreate
2006-08-06 08:40:13koweysettopic: + ProbablyEasy
2006-08-15 10:34:04simonsetstatus: unread -> unknown
nosy: + simon
messages: + msg905
2006-08-18 20:19:47lelesetnosy: + lele
messages: + msg920
title: darcs changes -s should show both adds and removes -> darcs changes -s should show both adds and removes
2006-08-18 21:35:10eschnettsetnosy: + eschnett
messages: + msg922
title: darcs changes -s should show both adds and removes -> darcs changes -s should show both adds andremoves
2006-08-31 22:58:30jchsetstatus: unknown -> resolved-in-unstable
nosy: droundy, tommy, eschnett, lele, bsoto, simon
2006-09-30 12:25:45tommysetstatus: resolved-in-unstable -> resolved-in-stable
nosy: + kowey
2007-06-29 19:39:17tommysetstatus: resolved-in-stable -> resolved
nosy: + beschmi
messages: + msg1761
2009-08-06 17:50:35adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, thorkilnaur, - droundy, eschnett, lele, bsoto
2009-08-06 20:50:08adminsetnosy: - beschmi
2009-08-10 21:51:57adminsetnosy: + eschnett, lele, bsoto, - markstos, darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 17:09:41adminsetnosy: + darcs-devel, - simon
2009-08-27 13:49:06adminsetnosy: tommy, kowey, darcs-devel, eschnett, lele, bsoto, thorkilnaur, dmitry.kurochkin
2010-04-03 12:58:59ganeshlinkpatch35 issues