Nobody should be receiving this through a mailing list. My new
avoid_test_spam flag should let me test changes to the BTS/email
integration without spamming darcs-*@

Sigh, no, really nobody should receive this now.

Fri Oct 15 17:10:08 CEST 2010  Eric Kow <kowey@darcs.net>
  * Two avoid_test_spam mistakes: boolean inversion and also type error.
    {
    hunk ./detectors/nosyreaction.py 39
    -    can_spam = getattr(db.config.detectors, 'avoid_test_spam', '') == 1
    +    can_spam = getattr(db.config.detectors, 'avoid_test_spam', '')
!= '1'
    hunk ./detectors/nosyreaction.py 80
    -    can_spam = getattr(db.config.detectors, 'avoid_test_spam', '') == 1
    +    can_spam = getattr(db.config.detectors, 'avoid_test_spam', '')
!= '1'
    }

No, really! this time it should work

Fri Oct 15 17:16:54 CEST 2010  Eric Kow <kowey@darcs.net>
  * Oops: forgot the setting is in all caps.
    {
    hunk ./detectors/nosyreaction.py 39
    -    can_spam = getattr(db.config.detectors, 'avoid_test_spam', '')
!= '1'
    +    can_spam = getattr(db.config.detectors, 'AVOID_TEST_SPAM', '')
!= '1'
    hunk ./detectors/nosyreaction.py 80
    -    can_spam = getattr(db.config.detectors, 'avoid_test_spam', '')
!= '1'
    +    can_spam = getattr(db.config.detectors, 'AVOID_TEST_SPAM', '')
!= '1'
    }

Sorry, everybody.  I'm sure you're all loving the
does-my-spam-avoidance-mechanism-work-now? spam

I'm doing this so that I can do more testing on roundup instance
(especially the bits that send email to people) without risking so much
collateral damage.  The goal is to be able to flip a single switch that
suppresses all noisy-behaviour to lists.


darcs changes --last=1 -v
Prehook ran successfully.
Fri Oct 15 17:20:33 CEST 2010  Eric Kow <kowey@darcs.net>
  * Oh, you need every setting to be in a section.
    {
    hunk ./detectors/nosyreaction.py 39
    -    can_spam = getattr(db.config.detectors, 'AVOID_TEST_SPAM', '')
!= '1'
    +    can_spam = getattr(db.config.detectors,
'DEBUG_AVOID_TEST_SPAM', '') != '1'
    hunk ./detectors/nosyreaction.py 80
    -    can_spam = getattr(db.config.detectors, 'AVOID_TEST_SPAM', '')
!= '1'
    +    can_spam = getattr(db.config.detectors,
'DEBUG_AVOID_TEST_SPAM', '') != '1'
    }
Posthook ran successfully.

I keep forgetting I have to restart Apache for changes to take effect.

I finally got it working!  (I had to restart Apache)

Sorry for the noise.  This is just a final test to make sure that
disabling the spam suppression flag results in messages being sent to
lists again.

Looks like Kowey was doing some testing here which is done now. 
Resolving.