When optimize --http is run on a repository whose pristine files are in
the "old" format (the kind of repo that issue a "one-time conversion"
warning message with recent darcses), the conversion is not done before
packs are created.
As a consequence, users see this "one-time conversion" message during
the "get".

optimize --http should rather run this conversion before building the packs.

This probably requires a refactor to the function
Darcs.Repository.HashedRepo.applyHashed so that the conversion can be
done on demand.

I have a patch that makes "darcs optimize --http" systematically run the
pristine upgrade before creating the basic pack (see
http://wiki.darcs.net/Internals/OptimizeHTTP), and I'm not sure this is
worth it.

With this patch, users will systematically see the warning message.

Without (current situation), the warning only happens during "darcs get"
from a packed repos who didn't have the pristine conversion. Since
"optimize --http" is only in recent darcses, which do this conversion as
soon as a patch is applied on a repo, it should only happen very seldom.

So, the cure is worse than the disease. I suggest we don't fix this.

On 03/04/2011 10:05, Guillaume Hoffmann wrote:
> 
> Guillaume Hoffmann <guillaumh@gmail.com> added the comment:
> 
> I have a patch that makes "darcs optimize --http" systematically run the
> pristine upgrade before creating the basic pack (see
> http://wiki.darcs.net/Internals/OptimizeHTTP), and I'm not sure this is
> worth it.
> 
> With this patch, users will systematically see the warning message.

Can't you first check if it's converted, using the same code that
already does that check?

> 
> Without (current situation), the warning only happens during "darcs get"
> from a packed repos who didn't have the pristine conversion. Since
> "optimize --http" is only in recent darcses, which do this conversion as
> soon as a patch is applied on a repo, it should only happen very seldom.

Given this it may not actually be worth the effort, of course.

Ganesh

> Can't you first check if it's converted, using the same code that
> already does that check?

There is no such directly usable code. This check is done by catching
an exception provoked by a pattern matching failure in
Darcs.Repository.Hashed , functions applyHashed and applyHashed'.

Is it just the error message that's the problem, or the fact that doing 
the conversion/check on an already pristine-optimised repo is slow?  If 
it's fast in practice, could we silently do it for optimize?