Issue 2074: AVOID: failure when aborting obliterate that will disallow unrevert - Darcs bug tracker

Title	AVOID: failure when aborting obliterate that will disallow unrevert
Priority	bug	Status	has-patch
Milestone		Resolved in
Superseder		Nosy List	owst
Assigned To		Topics	UI

Created on 2011-05-27.11:17:07 by owst, last changed 2023-03-28.17:34:09 by bfrk.

Messages
msg14470 (view)	Author: owst	Date: 2011-05-27.11:17:06
darcs init touch a darcs add a darcs rec -am 'a' echo "line1" > a darcs rev -a echo "yn" \| darcs ob causes "darcs failed: Cancelled." when the user has answered no to "This operation will make unrevert impossible!" in obliterate, because "fail" is called within "removeFromUnrevertContext" in src/Darcs/Repository/Internal.hs I don't think this should be a failure - the user has told darcs to stop.
msg16682 (view)	Author: kowey	Date: 2013-02-17.13:37:54
Yeah, this is a general thing. Failure should mean failure
msg23217 (view)	Author: bfrk	Date: 2023-03-28.17:31:07
Easy to fix, see patch2292.
msg23219 (view)	Author: bfrk	Date: 2023-03-28.17:34:08
I'd argue that this is a bug.

History
Date	User	Action	Args
2011-05-27 11:17:07	owst	create
2013-02-17 13:37:56	kowey	set	priority: feature status: unknown -> needs-implementation topic: + UI messages: + msg16682 title: Darcs failure when stopping obliterate that will disallow unrevert -> AVOID: failure when aborting obliterate that will disallow unrevert
2023-03-28 17:31:07	bfrk	set	status: needs-implementation -> has-patch messages: + msg23217
2023-03-28 17:34:09	bfrk	set	priority: feature -> bug messages: + msg23219