darcs

Issue 2226 make sure to do patch index creation last

Title make sure to do patch index creation last
Priority Status resolved
Milestone Resolved in
Superseder Nosy List ganesh
Assigned To
Topics Control-C, PatchIndex

Created on 2012-08-30.05:55:41 by ganesh, last changed 2012-10-10.17:58:27 by owst.

Files
File name Uploaded Type Edit Remove
unnamed bsrkaditya, 2012-08-30.10:51:41 text/html
Messages
msg16036 (view) Author: ganesh Date: 2012-08-30.05:55:39
On Windows, ^C doesn't really work properly and just aborts darcs 
instead of being caught. This works out ok in practice with getting lazy 
repos. 

But with the patch index creation and some commands like pull it leaves 
the working directory out of date with respect to the pulled patches.

As an aside we should provide a different interrupt mechanism on 
Windows..
msg16037 (view) Author: bsrkaditya Date: 2012-08-30.10:51:41
We could shift the update/create code from finalizeRepositoryChanges to the
end of main. That will work in most cases, unless darcs crashes somewhere
in the middle. That is okay, as the next run should take care of any
possible repository changes. There will be a small additional upkeep for
every run of darcs though.

Aditya.

On Thu, Aug 30, 2012 at 11:25 AM, Ganesh Sittampalam <bugs@darcs.net> wrote:

>
> New submission from Ganesh Sittampalam <ganesh@earth.li>:
>
> On Windows, ^C doesn't really work properly and just aborts darcs
> instead of being caught. This works out ok in practice with getting lazy
> repos.
>
> But with the patch index creation and some commands like pull it leaves
> the working directory out of date with respect to the pulled patches.
>
> As an aside we should provide a different interrupt mechanism on
> Windows..
>
> ----------
> messages: 16036
> nosy: ganesh
> status: unknown
> title: make sure to do patch index creation last
> topic: PatchIndex
>
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/issue2226>
> __________________________________
> _______________________________________________
> darcs-devel mailing list
> darcs-devel@darcs.net
> http://lists.osuosl.org/mailman/listinfo/darcs-devel
>



-- 
BSRK Aditya
Attachments
msg16224 (view) Author: owst Date: 2012-10-10.17:58:26
This was fixed in patch935, which has been accepted.
History
Date User Action Args
2012-08-30 05:55:41ganeshcreate
2012-08-30 06:32:45koweysettopic: + Control-C
2012-08-30 10:51:43bsrkadityasetfiles: + unnamed
messages: + msg16037
2012-09-09 14:58:24bsrkadityalinkpatch935 issues
2012-10-10 17:58:27owstsetstatus: unknown -> resolved
messages: + msg16224