darcs

Issue 2390 broken build

Title broken build
Priority Status resolved
Milestone Resolved in
Superseder Nosy List fx, ganesh, owst
Assigned To
Topics

Created on 2014-05-19.13:42:03 by fx, last changed 2014-11-25.07:02:16 by ganesh.

Messages
msg17465 (view) Author: fx Date: 2014-05-19.13:42:00
The patch

  Sat May  3 17:11:30 BST 2014  Owen Stephens <darcs@owenstephens.co.uk>
    * Use custom replHook to fix cabal repl
  
breaks the build for me:

  darcs.reviewed$ cabal build
  [1 of 1] Compiling Main             ( Setup.lhs, dist/setup/Main.o )
  
  Setup.lhs:37:58:
      Module `Distribution.Simple.Setup' does not export `replVerbosity'

Backing out just that from the current reviewed repo lets it build.
I don't know what installed stuff might be relevant, but I have:

  darcs.reviewed$ ghc --version
  The Glorious Glasgow Haskell Compilation System, version 7.4.1
  darcs.reviewed$ cabal --version
  cabal-install version 0.14.0
  using version 1.14.0 of the Cabal library
msg17505 (view) Author: gh Date: 2014-06-02.14:33:12
Owen, we probably have to rollback your patch, or can it be fixed?
msg17506 (view) Author: owst Date: 2014-06-02.14:54:20
We'd need to special case on the version of Cabal, so that only versions
>1.18 add the replHook.

I tried to use 
#if MIN_VERSION_Cabal(1,18,0)
replHook = ...
#endif

and similar around the import...

but that didn't seem to work - probably easiest to rollback the patch
instead.
msg17507 (view) Author: ganesh Date: 2014-06-02.16:23:27
There was a suggestion on IRC about fixing this using Template Haskell - 
I'll check into the details.
msg17512 (view) Author: ganesh Date: 2014-06-03.05:28:36
This was the idea: http://irclog.perlgeek.de/darcs/2014-05-09#i_8702735

Do we think it's worth the ugliness? I think it probably is because 'cabal 
repl' is very worth having.
msg17514 (view) Author: ganesh Date: 2014-06-03.17:57:54
patch1168 seems to work, but is it worth it?

My feeling is yes but keep a close eye to see if any problems show up.
History
Date User Action Args
2014-05-19 13:42:05fxcreate
2014-06-02 14:32:53ghsetnosy: + owst
2014-06-02 14:33:14ghsetmessages: + msg17505
2014-06-02 14:54:21owstsetmessages: + msg17506
2014-06-02 16:23:28ganeshsetnosy: + ganesh
messages: + msg17507
2014-06-03 05:28:37ganeshsetmessages: + msg17512
2014-06-03 17:56:13ganeshlinkpatch1168 issues
2014-06-03 17:57:55ganeshsetstatus: unknown -> has-patch
messages: + msg17514
2014-11-25 07:02:16ganeshsetstatus: has-patch -> resolved