Issue 2568 --unified option broken for most commands

Title --unified option broken for most commands
Priority Status resolved
Milestone Resolved in
Superseder Nosy List bfrk
Assigned To

Created on 2018-02-19.10:14:29 by bfrk, last changed 2024-06-29.11:05:43 by bfrk.

msg19907 (view) Author: bfrk Date: 2018-02-19.10:14:27
See also issue2567 which fixed (restores) the correct behavior for
whatsnew, unless used interactively. All other commands that support the
option display hunks only in interactive mode, which is definitely
broken (tested with darcs-2.10.2).

The point to note here is that the functionality is inherently stateful:
each hunk changes the context of later hunks in the same file.

Fixing this is not completely trivial. The interactive selection process
for prim patches must keep track of the state, presumably by working in
a VirtualTreeIO monad.

We need a way to test output in interactive mode. I have no idea how to
do that ATM.

We should also rename the option (--unified, WTH?). I propose
--with-context or --show-context.
msg19909 (view) Author: bfrk Date: 2018-02-20.00:13:43
I am half of a mind to disable (i.e. temporarily remove) the option for
most commands except for whatsnew in non-interactive mode until this
issue is fixed.
msg24058 (view) Author: bfrk Date: 2024-06-29.11:05:43

patch 4d70f3af1951fe7226380c16d209407539f228b8
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov 16 14:32:05 CET 2021
  * remove withContext/unified option except for non-interactive 
Date User Action Args
2018-02-19 10:14:29bfrkcreate
2018-02-20 00:13:45bfrksetmessages: + msg19909
2024-06-29 11:05:43bfrksetstatus: unknown -> resolved
messages: + msg24058