Issue 2706 tests failing because of extra "Identifying Repository ." output

Title tests failing because of extra "Identifying Repository ." output
Priority Status resolved
Milestone Resolved in
Superseder Nosy List ganesh
Assigned To

Created on 2023-06-21.01:08:12 by ganesh, last changed 2023-06-24.00:16:40 by ganesh.

msg23339 (view) Author: ganesh Date: 2023-06-21.01:08:11
Various tests, including issue2209, are failing for me at the tip of
reviewed. Provisionally, the cause seems to be that darcs is now
printing out extra "Identifying Repository ." statements at the top
of its output, which affects the count of lines to drop when we pass
it into 'tail'.

I tracked it down to
>   * improve and simplify progress reporting
from http://bugs.darcs.net/patch2282

but haven't dug further or fully confirmed what I think I'm seeing
with the output.

A relevant factor in only just noticing this may be my new laptop
which is running Windows 11 and a hence a new terminal program
for my WSL2 shells.
msg23343 (view) Author: bfrk Date: 2023-06-21.11:32:02
I can reproduce this on my laptop with ubuntu-18.04, so OS/version are 
probably irrelevant. It does not happen with screened, so there must 
be a patch in screened that fixes this. Will investigate.
msg23344 (view) Author: bfrk Date: 2023-06-21.13:05:17

patch d92b0ac32c52654a850094fb81f6b254379ed815
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov 22 19:17:25 CET 2022
  * improve error reporting when remote _darcs/format doesn't exist

from screened seems to fix this particular issue because that patch 
removes the progress reporting from tryIdentifyRepoFormat. This 
reduces the number of failed tests from 7 to 5.
msg23358 (view) Author: bfrk Date: 2023-06-23.10:42:25
The simplest way to fix this is by applying

patch dc1f597e0c48fec5a415d6e5f0bcd342f5717331
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Mar 12 10:55:16 CET 2023
  * progress reporting: fix for non-native Windows terminals and 

from bundle patch2291
msg23361 (view) Author: ganesh Date: 2023-06-24.00:16:18
reviewed seems to be working now, thanks!
Date User Action Args
2023-06-21 01:08:12ganeshcreate
2023-06-21 11:32:02bfrksetmessages: + msg23343
2023-06-21 13:05:17bfrksetmessages: + msg23344
2023-06-23 10:42:25bfrksetmessages: + msg23358
2023-06-23 11:54:56bfrksetstatus: unknown -> resolved
2023-06-24 00:16:19ganeshsetstatus: resolved -> unknown
messages: + msg23361
2023-06-24 00:16:40ganeshsetstatus: unknown -> resolved