Issue 2712 selection: how to treat already decided patches

Title selection: how to treat already decided patches
Priority feature Status unknown
Milestone Resolved in
Superseder Nosy List bfrk
Assigned To

Created on 2023-08-27.14:47:34 by bfrk, last changed 2023-08-27.14:52:27 by bfrk.

msg23702 (view) Author: bfrk Date: 2023-08-27.14:47:32
We currently skip any already decided patches when we are done with 
the current one. This is sub-optimal in that it makes it hard to 
undo selections. Example: you have selected the last three offers 
and then have a change of mind. To deselect them you have to say 
knkknkkkn. It's especially bad when splitting patches after going 
back, where the current policy means that if you split an already 
decided patch into two, you are offered the first, but not the 
second part (because the splitted patches inherit the selection 

On the other hand we usually don't want to be asked for patches that 
have been selected implicitly via dependencies. But we currently 
have no way to distinguish between manually and implicitly decided 
patches, so we'd first have to add build in such a distinction 
before we can change skipMundane so that it only skips implicitly 
decided patches.
msg23703 (view) Author: bfrk Date: 2023-08-27.14:52:27
Fixing (only) the behavior when splitting already decided patches is 
easy: we just have to undecide them before we split. I think that 
makes sense and I will send a patch that does this.
Date User Action Args
2023-08-27 14:47:34bfrkcreate
2023-08-27 14:52:27bfrksetmessages: + msg23703