Consider the following two calls (cut-and-pasted from my terminal).

How can the presence of that final "l" make the pattern invalid?

darcs v1.0.8.

Regards,

Zooko

zooko@hanford:~/trees/trunk$ darcs diff -u --match "name \"dbutil: convert ValueError? from DB.l\""

darcs failed:  Couldn't match pattern "name "dbutil: convert ValueError? from DB.l""
zooko@hanford:~/trees/trunk$ darcs diff -u --match "name \"dbutil: convert ValueError? from DB.\""
Tue Nov  7 16:14:39 PST 2006  zooko@zooko.com
  * dbutil: convert ValueError from DB.__len__() into DBError
diff -rN -u old-trunk/trunk/amdlib/util/dbutil.py new-trunk/trunk/amdlib/util/dbutil.py
--- old-trunk/trunk/amdlib/util/dbutil.py       2006-11-08 12:30:29.000000000 -0800
+++ new-trunk/trunk/amdlib/util/dbutil.py       2006-11-08 12:30:30.000000000 -0800
@@ -86,7 +86,13 @@

     @retry
     def __len__(self):
-        return len(self.o)
+        try:
+            return len(self.o)
+        except ValueError, le:
+            # Corrupted db's can sometimes yield this error:
+            # "exceptions.ValueError: __len__() should return >= 0".  Here we
+            # convert those to DBError.
+            raise DBError(le)

     @retry
     def __getitem__(self, i):

The patch name contains "DB.__len__" and you're searching for "DB.l", which
isn't there. You probably meant to put "DB.__l".

> 
> Grant Husbands <darcsbugs2@grant.x43.net> added the comment:
> 
> The patch name contains "DB.__len__" and you're searching for "DB.l", which
> isn't there. You probably meant to put "DB.__l".

Thanks!

Zooko wrote:
> How can the presence of that final "l" make the pattern invalid?
>
> zooko@hanford:~/trees/trunk$ darcs diff -u --match "name \"dbutil: convert ValueError? from DB.l\""
> 
> darcs failed:  Couldn't match pattern "name "dbutil: convert ValueError? from DB.l""
> zooko@hanford:~/trees/trunk$ darcs diff -u --match "name \"dbutil: convert ValueError? from DB.\""
> Tue Nov  7 16:14:39 PST 2006  zooko@zooko.com
>   * dbutil: convert ValueError from DB.__len__() into DBError

It looks to me like it's because there's no patch matching the first 
pattern.

Edwin