darcs

Issue 386 darcs push --dry-run --match prints out a bogus message

Title darcs push --dry-run --match prints out a bogus message
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tim, tommy
Assigned To kowey
Topics ProbablyEasy

Created on 2007-01-11.16:07:37 by tim, last changed 2009-08-27.14:11:29 by admin.

Messages
msg1399 (view) Author: tim Date: 2007-01-11.16:07:30
I did the following in my repository:

krc@bongo:~/ghc-hacking$ darcs push --dry-run
kirsten@darcs.haskell.org:/home/darcs/ghc
Would push the following changes:
[changes snipped]
Making no changes:  this is a dry run.

darcs worked correctly in that case. Then I tried doing this:

krc@bongo:~/ghc-hacking$ darcs push --dry-run
kirsten@darcs.haskell.org:/home/darcs/ghc --match 'name Remove'
Pushing to "kirsten@darcs.haskell.org:/home/darcs/ghc"...
Would push the following changes:
[changes snipped]
Making no changes:  this is a dry run.

Notice that the first line it prints out is "Pushing to..." even though it's a
dry run. I checked, and the patches didn't actually get pushed; it was the
message that was wrong. It would seem that this happens when you combine
--dry-run with --match, since it printed out the right messages when I just did
--dry-run.

This seems to be pretty clearly a bug (and probably took several years off my
life before I confirmed that it did not, in fact, push my patches).
History
Date User Action Args
2007-01-11 16:07:37timcreate
2007-07-21 06:44:11koweysettopic: + ProbablyEasy
nosy: droundy, tommy, beschmi, kowey, tim
2007-07-31 17:56:12koweysetstatus: unread -> resolved-in-stable
2008-09-16 21:30:46adminsetstatus: resolved-in-stable -> resolved
nosy: + dagit
2009-08-06 17:38:26adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, tim
2009-08-06 20:35:13adminsetnosy: - beschmi
2009-08-10 22:00:43adminsetnosy: + tim, - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:59:00adminsetnosy: - dagit
2009-08-25 17:52:03adminsetnosy: + darcs-devel, - simon
2009-08-27 14:11:29adminsetnosy: tommy, kowey, darcs-devel, tim, thorkilnaur, dmitry.kurochkin