The test uses a trivial shell script to stand in for ssh, via the DARCS_SSH
environment variable.

For some reason, darcs insists on using ssh instead of that trivial shell script.

And strangely, the test to make sure it's not (just) doing that passes (we check
to see if the script was launched, i.e. if it created the fake-ssh file, and
indeed it does).

I know it's trying to call the real ssh somewhere because if I replace foo.bar
with darcs.net, I get a passphrase prompt.

Puzzled.

Thanks for the report Eric. What's your shell environment that this happens in?
(zsh again?). Do you have alternate shell to try running the script in?

You can emulate how the test suite runs the test and still run just one test
like this:

cd ./test
./bin/prove -v external.pl

(a shell script would be: perl shell_harness script.sh).

I think Eric that this bug is fixed by the patch you sent in? I'm tentatively
setting this to resolved, please correct me if I'm wrong.

On Tue, Feb 05, 2008 at 15:40:33 -0000, David Roundy wrote:
> I think Eric that this bug is fixed by the patch you sent in? I'm tentatively
> setting this to resolved, please correct me if I'm wrong.

To my dismay (and surprise), no, it is not fixed by my patch.
Huh...

Eric,

Let's get a rundown of your environment where this bug is triggered. The test
passes for me under these conditions, with Darcs 1.0.9, or a recent build from
"unstable", built with GHC 6.6.1:

- Perl 5.8.8
- Bash 3.2.25
- Ubuntu Gutsy Linux 7.10. 

Is this on Windows by chance? I do see a line in script that is Windows-specific.

Argh, this really should have fallen under the
if-it-takes-less-than-two-minutes-do-it-right-now rule

Hmm... now passes under MacOS X 10.5 :-/ Any Tiger users see this fail? It may
be worth getting a slave for the buildbot.

Bah.  I'm marking this resolved.  In the worst case, we can move the relevant
test to network/

Passing:
- MacOS X 10.5 (darwin 9.2.2)
- zsh 4.3.4
- Perl 5.8.8

Failing:
- MacOS X 10.4
- zsh ???
- Perl ???