Created on 2008-06-12.11:42:43 by benjamin.franksen, last changed 2009-10-23.23:45:52 by admin.
msg5020 (view) |
Author: bfr |
Date: 2008-06-12.11:42:41 |
|
A patch in which the patch name contains a funny sequence of
characters, originally meant to be a 'ü', gets displayed colorized, which I
think, should not be.
This is the relevant part of the outout:
aragon: .../PITZ-Controls/tailor > darcs
changes --repo=tailor_d1 --xml-output --patches='rkmann' | grep name
<name>Versions 42 (Modulator) and 10 (Gun) as sent by K.B\fcrkmann
to Jakob Rytter on 06-06-06</name>
and this is what it looks like byte by byte, look for 'esc':
aragon: .../PITZ-Controls/tailor > darcs
changes --repo=tailor_d1 --xml-output --patches='rkmann' | grep name |
od -t x1 -t a
0000000 09 3c 6e 61 6d 65 3e 56 65 72 73 69 6f 6e 73 20
ht < n a m e > V e r s i o n s sp
0000020 34 32 20 28 4d 6f 64 75 6c 61 74 6f 72 29 20 61
4 2 sp ( M o d u l a t o r ) sp a
0000040 6e 64 20 31 30 20 28 47 75 6e 29 20 61 73 20 73
n d sp 1 0 sp ( G u n ) sp a s sp s
0000060 65 6e 74 20 62 79 20 4b 2e 42 1b 5b 30 31 3b 33
e n t sp b y sp K . B esc [ 0 1 ; 3
0000100 31 6d 5c 66 63 1b 5b 30 30 6d 72 6b 6d 61 6e 6e
1 m \ f c esc [ 0 0 m r k m a n n
0000120 20 74 6f 20 4a 61 6b 6f 62 20 52 79 74 74 65 72
sp t o sp J a k o b sp R y t t e r
0000140 20 6f 6e 20 30 36 2d 30 36 2d 30 36 3c 2f 6e 61
sp o n sp 0 6 - 0 6 - 0 6 < / n a
0000160 6d 65 3e 0a
m e > nl
0000164
This happens with both darcs-1.09 and darcs-2.00.
A stop-gap work-around is to
export DARCS_DONT_COLOR=1
Ben
|
msg5021 (view) |
Author: kowey |
Date: 2008-06-12.11:53:35 |
|
This one is really a needs-volunteer.
See http://wiki.darcs.net/index.html/DarcsInternals particularly, the
ColourPrinter link.
Lele, I am inviting you to work on this one if you are interested. It may be a
good way to familiarise yourself with yet another component of darcs, now that
you've got an idea what's going on with the XML stuff. Would you be willing to
have a look?
|
msg5022 (view) |
Author: kowey |
Date: 2008-06-12.11:56:39 |
|
Oh, there is a perhaps a deeper issue about why darcs is trying to print umlauts
as \fc and what not.
But I think that gets us into http://bugs.darcs.net/issue64 and
http://bugs.darcs.net/issue33 which is a whole other discussion :-)
|
msg5038 (view) |
Author: bfr |
Date: 2008-06-13.13:35:26 |
|
The '\fc' for the 'ü' is not darcs' fault, it is simply the iso88591 encoding.
We switched to utf8 some time after this patch was recorded.
|
msg5039 (view) |
Author: kowey |
Date: 2008-06-13.13:45:28 |
|
Well the backslash-hexcode thing ('\fc') is definitely darcs-specific (see
<http://darcs.net/manual/node5.html#env:DARCS_DONT_ESCAPE_nonascii>), although
maybe you meant something else.
That said, wouldn't the UTF-8 encoded version of the same character involve two
backslash-hexcode sequences in darcs?
|
msg5051 (view) |
Author: kowey |
Date: 2008-06-16.10:16:56 |
|
Resolved by
Fri Jun 13 12:09:22 BST 2008 benjamin.franksen@bessy.de
* fix issue #918: use simplePrinters for xml output in "darcs changes" command
|
|
Date |
User |
Action |
Args |
2008-06-12 11:42:43 | benjamin.franksen | create | |
2008-06-12 11:47:16 | kowey | link | issue919 superseder |
2008-06-12 11:53:38 | kowey | set | status: unread -> has-patch priority: bug nosy:
+ lele, kowey, jaredj messages:
+ msg5021 topic:
+ ProbablyEasy assignedto: lele |
2008-06-12 11:56:42 | kowey | set | nosy:
tommy, beschmi, kowey, dagit, lele, benjamin.franksen, jaredj messages:
+ msg5022 title: Darcs generates invalid xml output -> darcs attempts to colorize escaped characters in XML output |
2008-06-13 13:35:28 | bfr | set | nosy:
+ bfr messages:
+ msg5038 |
2008-06-13 13:45:30 | kowey | set | nosy:
tommy, beschmi, kowey, dagit, lele, benjamin.franksen, jaredj, bfr messages:
+ msg5039 |
2008-06-16 10:16:58 | kowey | set | status: has-patch -> resolved-in-unstable nosy:
tommy, beschmi, kowey, dagit, lele, benjamin.franksen, jaredj, bfr messages:
+ msg5051 assignedto: lele -> |
2008-08-05 23:27:14 | kowey | set | status: resolved-in-unstable -> resolved nosy:
tommy, beschmi, kowey, dagit, lele, benjamin.franksen, jaredj, bfr |
2009-08-06 21:07:52 | admin | set | nosy:
+ dmitry.kurochkin, simon, thorkilnaur, - beschmi |
2009-08-11 00:17:03 | admin | set | nosy:
- dagit |
2009-08-25 18:12:26 | admin | set | nosy:
+ darcs-devel, - simon |
2009-08-27 14:01:48 | admin | set | nosy:
tommy, kowey, darcs-devel, lele, benjamin.franksen, thorkilnaur, jaredj, dmitry.kurochkin, bfr |
2009-10-23 22:35:10 | admin | set | nosy:
- bfr |
2009-10-23 23:45:52 | admin | set | nosy:
+ bfr, - benjamin.franksen |
|