Issue 942 Destination prehook is not invoked when pushing

Title Destination prehook is not invoked when pushing
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy, virgil
Assigned To

Created on 2008-07-02.16:23:49 by virgil, last changed 2009-09-04.11:16:40 by kowey.

msg5168 (view) Author: virgil Date: 2008-07-02.16:23:44
I set up a prehook in a repository by adding "apply prehook foo" to  
prefs/defaults. Now when pushing to that repository darcs says:

> The following command is set to execute.
> Execute the following command now (yes or no)?
> foo

But then darcs goes ahead and applies the change without waiting for a  
response or running the command.

This is with 2.0.2 on OS X.
msg5180 (view) Author: kowey Date: 2008-07-04.08:48:53
Virgil: thanks for the bug report!  Any chance you would be willing to submit a
test script for this (as a patch to our bugs/ directory, preferably).

Assigning to myself to reproduce and investigate.
msg5534 (view) Author: kowey Date: 2008-08-15.06:58:24
Unassigning myself.  We need a volunteer to write a small test script for this,
likely in bugs/
msg8686 (view) Author: kowey Date: 2009-09-04.11:16:38
Hi Virgil,

I notice that Darcs 2.1.1 has the patch:

Thu Oct 30 18:55:08 CET 2008  David Roundy <droundy@darcs.net>
  * make default be to --run-posthook and --run-prehook

which I think solves the problem.  Here is the test I made for it, which I
intend to submit to our regression testing suite .

rm -rf R S                      # Another script may have left a mess.
darcs init      --repo R        # Create our test repos.
echo 'apply prehook echo prehook fired' >R/_darcs/prefs/defaults
darcs get R S
cd S
touch f
darcs add f
darcs record -lam 'Add f'
darcs push -a > log
grep 'prehook fired' log

If this is not quite the same thing, please let me know.
Date User Action Args
2008-07-02 16:23:49virgilcreate
2008-07-04 08:47:25koweylinkissue943 superseder
2008-07-04 08:48:55koweysetpriority: bug
nosy: + kowey
status: unread -> unknown
messages: + msg5180
assignedto: kowey
2008-08-15 06:58:26koweysetstatus: unknown -> needs-reproduction
nosy: + darcs-devel, virgil, - virgil
messages: + msg5534
assignedto: kowey ->
2009-08-06 21:08:52adminsetnosy: + dmitry.kurochkin, simon, thorkilnaur, - beschmi
2009-08-11 00:17:58adminsetnosy: - dagit
2009-08-25 18:12:56adminsetnosy: - simon
2009-08-27 14:02:55adminsetnosy: tommy, kowey, darcs-devel, thorkilnaur, dmitry.kurochkin, virgil
2009-09-04 11:16:40koweysetstatus: needs-reproduction -> resolved
nosy: + virgil, - virgil
messages: + msg8686