darcs

Patch 1013 import encoding code from haskeline: Set... (and 5 more)

Title import encoding code from haskeline: Set... (and 5 more)
Superseder Nosy List ganesh
Related Issues
Status accepted Assigned To
Milestone

Created on 2013-01-20.18:24:08 by ganesh, last changed 2014-11-16.15:27:05 by ganesh.

Files
File name Status Uploaded Type Edit Remove
import-encoding-code-from-haskeline_-setup_lhs-changes.dpatch ganesh, 2013-01-20.18:24:07 application/x-darcs-patch
patch-preview.txt ganesh, 2013-01-20.18:24:07 text/x-darcs-patch
unnamed ganesh, 2013-01-20.18:24:07
See mailing list archives for discussion on individual patches.
Messages
msg16543 (view) Author: ganesh Date: 2013-01-20.18:24:07
Here's take two at sorting out encoding for GHC 7.6.

I've given up on using GHC's built-in encoding functionality for now,
because of a couple of problems:

- badly encoded strings can cause segfaults:
http://hackage.haskell.org/trac/ghc/ticket/7522

 - the set of Windows codepages known by GHC isn't very
comprehensive - e.g. the ISO-8859-15 equivalent, 28605,
is missing.

I still hope to switch over at some point in the future
once these problems are solved, but for now I've extracted
the encoding-related code from haskeline and put it
directly in darcs.

6 patches for repository darcs-unstable@darcs.net:screened:

Tue Jan 15 18:10:40 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * import encoding code from haskeline: Setup.lhs changes

Fri Jan 18 07:35:57 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * import encoding code from haskeline: cabal changes

Fri Jan 18 22:59:47 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * import encoding code from haskeline: source files

Fri Jan 18 23:01:19 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * import encoding code from haskeline: switch over

Fri Jan 18 23:02:38 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * import encoding code from haskeline: move source into Darcs.Util

Sat Jan 19 16:36:10 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * add copyright notices for the imported haskeline code
  licence/copyright taken from haskeline 0.6.4.7:
  BSD3, copyright Judah Jacobson
Attachments
msg16586 (view) Author: ganesh Date: 2013-02-14.22:55:27
The slightly convoluted setup code for iconv seems to go wrong in some 
circumstances:

http://irclog.perlgeek.de/darcs/2013-02-13#i_6446470
msg16591 (view) Author: gh Date: 2013-02-15.11:36:36
Makes darcs compile with GHC 7.6.
msg17821 (view) Author: ganesh Date: 2014-11-16.15:27:05
Just adding a note for reference as I was just tracking down the 
history: "take two" was needed because of the problems  with the 
previous attempt - see patch987 and issue2286.
History
Date User Action Args
2013-01-20 18:24:08ganeshcreate
2013-02-14 15:32:45ghsetstatus: needs-screening -> needs-review
2013-02-14 22:55:27ganeshsetmessages: + msg16586
2013-02-15 11:36:36ghsetstatus: needs-review -> accepted
messages: + msg16591
2014-11-16 15:27:05ganeshsetmessages: + msg17821