Patch 107 replace if-statement with guard in elegant_merge

Title replace if-statement with guard in elegant_merge
Superseder Nosy List dagit, darcs-users, ganesh, kowey
Related Issues
Status accepted Assigned To ganesh

Created on 2009-12-07.22:14:17 by dagit, last changed 2011-05-10.21:06:55 by darcswatch. Tracked on DarcsWatch.

File name Status Uploaded Type Edit Remove
replace-if_statement-with-guard-in-elegant_merge.dpatch dagit, 2009-12-07.22:14:16 text/x-darcs-patch
replace-if_statement-with-guard-in-elegant_merge.dpatch dagit, 2010-03-18.03:02:30 text/x-darcs-patch
unnamed dagit, 2009-12-07.22:14:16 text/plain
unnamed dagit, 2010-03-18.03:02:30 text/plain
See mailing list archives for discussion on individual patches.
msg9554 (view) Author: dagit Date: 2009-12-07.22:14:16
This is really a follow up to patch61 (which has been accepted so I
felt it was right to start a new ticket).

I've opted to leave the unsafeCompare in there because I'm worried
that removing it without a proper investigation could lead to a change
in behavior.  Especially in corner cases.

I removed the comment because now that it's using the Maybe monad the
check for "Nothing -> Nothing" is hidden and I think that is what the
comment was referring to.  I also think the unsafeCompare is
redundant, and previously I thought the comment applied to that
operation, but looking at the original code again I changed my mind.


Mon Dec  7 14:09:49 PST 2009  Jason Dagit <dagit@codersbase.com>
  * replace if-statement with guard in elegant_merge
msg9560 (view) Author: ganesh Date: 2009-12-08.08:24:53
Code is fine, but if we're keeping the redundant test we should also keep the
comment about it.
msg10259 (view) Author: dagit Date: 2010-03-18.03:02:31
This should be the amendment Ganesh asked for.


Wed Mar 17 20:00:51 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * replace if-statement with guard in elegant_merge
msg10266 (view) Author: kowey Date: 2010-03-18.08:16:03
On Thu, Mar 18, 2010 at 03:02:31 +0000, Jason Dagit wrote:
> This should be the amendment Ganesh asked for.

I'll apply this, thanks!

Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg10281 (view) Author: darcswatch Date: 2010-03-18.22:05:51
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
msg14069 (view) Author: darcswatch Date: 2011-05-10.17:36:33
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
Date User Action Args
2009-12-07 22:14:17dagitcreate
2009-12-07 22:18:04darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-f6100f967b447c2397c4e71bc40ce45715bd7268
2009-12-08 08:24:54ganeshsetstatus: needs-review -> followup-requested
assignedto: ganesh
messages: + msg9560
nosy: + ganesh
2010-03-18 03:02:31dagitsetfiles: + replace-if_statement-with-guard-in-elegant_merge.dpatch, unnamed
messages: + msg10259
2010-03-18 03:04:18darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-f6100f967b447c2397c4e71bc40ce45715bd7268 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-6f149acf74c7967d73f6f5304c73609842ff480d
2010-03-18 08:16:03koweysetnosy: + kowey
messages: + msg10266
2010-03-18 22:05:56darcswatchsetstatus: followup-requested -> accepted
messages: + msg10281
2011-05-10 17:36:33darcswatchsetmessages: + msg14069
2011-05-10 21:06:55darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-6f149acf74c7967d73f6f5304c73609842ff480d -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-f6100f967b447c2397c4e71bc40ce45715bd7268